Second round of cleanups. #54
Conversation
applespi.c
Outdated
| /* | ||
| * MacBook (Pro) SPI keyboard and touchpad driver | ||
| * | ||
| * Copyright (c) 2015-2017 Federico Lorenzi |
There was a problem hiding this comment.
@roadrunner2: Given the work you put into that driver, you should add yourself there as author as well. You truly deserve it!
There was a problem hiding this comment.
Thanks, but it's fine. Federico did the original work, without which I wouldn't have had anything to contribute to.
There was a problem hiding this comment.
I definitely agree with @Dunedan here, you've done all the heavy lifting into getting the reverse engineered proof of concept I had into shape!
|
So this is almost too minor to mention, but just to avoid objections once it gets posted to the mailing list, in 7e51eac, for multi-line comments, kernel convention is to leave the first line empty and for single-line comments to not use caps, e.g.: The GPL license text at the top can be replaced with: Everything else LGTM. Thanks! |
|
Looks good to me, thanks @roadrunner2! |
Put all the module notes together in their respective paragraphs. Added note about ensuring the modules are put in the initrd and that doing so appears to solve the irqpoll issue on these machines. Simplified instructions for setting up the modules in the initrd.
Replaced raw __set_bit()'s with input_set_capability() for consistency. With this the explicit setting of evbit is not necessary. Also, removed duplicate BTN_LEFT setting.
These are all style issues found by checkpatch.pl with --strict. No functional changes.
As pointed out by Lukas Wunner.
roadrunner2
force-pushed
the
cleanups2
branch
from
024b94b to
31771d3
Compare
This is a second set of code cleanups - the largest part is the ones flagged by checkpatch (so hopefully that will avoid style complaints when we attempt to upstream this 😉 ).
After this I have some small fixes and enhancements lined up, plus finally the refinement of the packet/message data structures (including support multi-packet messages, and with that for more than 6 fingers).