Formatting cleanup #48
Conversation
This includes: * limiting line lengths to 80 chars * putting return type on same line as function name in function declarations * ensuring space around binary operators * replacing C++ // comments with C /* */ comments No functional changes.
It is apparently safe to initialize these once and keep re-using them. A number of existing drivers do this already. Also inlined applespi_setup_spi_message() since it's only used in two places and didn't seem to be worth it. This is in response to a review by Lukas Wunner.
|
Added another commit on top here in response to @l1k's comments. It's not a formatting cleanup, but it just refactors the code a bit, so still no functional change. |
|
Just ran this through |
|
To mainline, put it somewhere in drivers/input/ (keyboard? misc?), add Kconfig and Makefile entries, add copyright + license header to the file, write a commit message which explains a bit which machines this is for and how it works, add Signed-off-by for all contributors, send it to the list and maintainers, cc everyone who might be relevant. git only allows a single author unfortunately, that's probably either of Federico or Ronald. The patch might have to go through the merry-go-round a couple of times, depends on the maintainers, some are lax and some are picky. I've no past experience with the input maintainers. Once the driver gets merged, it will be a bit more cumbersome to make changes as everything goes through the regular review process on mailing lists, instead of informal pull requests on GitHub. Let me know if you need help with any of these steps. |
Just some basic cleanups. No functional change.