applespi: Fix reading of touchpad init response. #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A delay is needed after deasserting cs and before reading the response, otherwise the response may contain leading garbage bytes (typically 3). I only saw this issue when the gpe17 interrupt (from the EC) was triggering like crazy, something that is often but not always the case.
|
Good catch. We probably should start looking at the response. I believe you said you made some good headway in decoding the packet format properly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't actually causing any issues AFAICT, since we currently don't look at the response, but nevertheless I figure it doesn't hurt.