applespi: Add keyboard-backlight support. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the backlight appears to not turn on till level 32, so we adjust the range so that a value of 1 turns on the backlight.
roadrunner2
force-pushed
the
keyboard-backlight
branch
from
b825386 to
9d339dd
Compare
|
Works fine. 👍 |
|
@roadrunner2 this is great! Confirmed working on my Macbook9,1, so I'm going to go ahead and merge it. Really oddly, it seems like the SPI issues I was having previously have vanished. No idea what was going on there. |
|
@cb22 Interesting about the SPI issues vanishing. I suppose that's both good and bad news: good that it's working for you now, but bad in that it's leaving me worried we still have some sporadic issue here and no way to debug it. Oh well, will have to wait and see if anybody else complains of the same problem. Thanks for merging this and all the other pull requests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume you already started adding this functionality to the driver, but I got impatient and too excited about having the backlight working after you posted your traces in Dunedan/mbp-2016-linux#16 that I went ahead and created this. Feel free to ignore, trash, plunder, or otherwise do what you like with this.