Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Commit

Permalink
Add 'npm run lint' to PR build
Browse files Browse the repository at this point in the history
Discovered in tektoncd#182 (comment) that our JS linter is not being run on PR builds.
Add it to node_test so we can capture these issues and provide faster feedback
to developers without requiring manual review/testing of code style, unused
variables/imports etc.

Also add the node-* folder (used in PR builds) to .gitignore to avoid
issues with unexpected lint config references.
  • Loading branch information
AlanGreene authored and tekton-robot committed May 30, 2019
1 parent 7e6c003 commit be830b8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ main
# dependencies
/node_modules
/vendor
/node-*

# misc
npm-debug.log
Expand All @@ -20,5 +21,3 @@ yarn-error.log
# System Files
.DS_Store
Thumbs.db


1 change: 1 addition & 0 deletions test/presubmit-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ function node_test() {
local failed=0
echo "Running node tests from $(pwd)"
node_npm_install || failed=1
npm run lint || failed=1
npm run test:ci || failed=1
echo ""
return ${failed}
Expand Down

0 comments on commit be830b8

Please sign in to comment.