Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(seventv): init #1491

Merged
merged 8 commits into from
Dec 31, 2024
Merged

feat(seventv): init #1491

merged 8 commits into from
Dec 31, 2024

Conversation

mxgic1337
Copy link
Member

🎉 Theme for 7TV 🎉

7TV is a platform and a browser extension that provides custom emotes for Twitch.
Preview

💬 Additional Comments 💬

This userstyle only themes the 7tv.app website. The extension is unthemed.

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@mxgic1337 mxgic1337 requested a review from a team as a code owner December 14, 2024 13:51
@uncenter uncenter mentioned this pull request Dec 24, 2024
19 tasks
@mxgic1337 mxgic1337 requested a review from uncenter as a code owner December 29, 2024 16:58
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, 1 small issue with the gradients
Uploading image.png…

@mxgic1337
Copy link
Member Author

@isabelroses What is the issue? Also, should I rename the file to catppuccin.user.less?

@isabelroses
Copy link
Member

Oh the image didn't upload...
image

Also, should I rename the file to catppuccin.user.less?

Yes, you can also remove the vim line at the bottom of the file.

@mxgic1337
Copy link
Member Author

I'm not sure how I should style these gradients.

@isabelroses
Copy link
Member

I'm not sure how I should style these gradients.

Thats pretty fair. I don't mind removing them since there is a few. Alternatively, you could reduce them a little. Like I choose herre

radial-gradient(150% 180% at 50% 180%, #fab387, #f9e2af 1%, #cba6f7 25%, #181825 75%), var(--secondary) !important

cc: @uncenter

@mxgic1337 mxgic1337 merged commit 063afe5 into catppuccin:main Dec 31, 2024
2 checks passed
@uncenter
Copy link
Member

This was not approved by both staff members, as is required. Only staff should be merging init pull requests.

@uncenter
Copy link
Member

I'm going to leave review comments on this pull request hopefully later today that will need to be addressed in a follow up PR.

@mxgic1337
Copy link
Member Author

This was not approved by both staff members, as is required. Only staff should be merging init pull requests.

Oops, I thought that only one approval is required, sorry!

@uncenter
Copy link
Member

No worries, we need to work on our documentation and maintainer flow! It's definitely not clear at the moment. See the new "Custom GitHub bot" section on #1357 for what it might look like in the future :)

@uncenter
Copy link
Member

I'm going to leave review comments on this pull request hopefully later today that will need to be addressed in a follow up PR.

Looks really good! No changes from me, thanks for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants