-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mullvad-leta): init #1481
feat(mullvad-leta): init #1481
Conversation
4069216
to
429ccda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but theres no way to test without a mullvad vpn account.
cc: @uncenter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good going by the preview image! Seeing as this is a relatively simple port and you are already a maintainer I think we can take you at your word that everything is themed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the logo in the center of the search page as seen in the preview screenshot themable as an SVG? https://github.com/catppuccin/userstyles/blob/main/docs/guide/images-and-svgs.md#img-elements
If possible can we avoid autogenerated classnames like
What color are the links on hover and what color are visited links? |
They're all the same, they use underline decoration for hover and nothing for visited links. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
🎉 Theme for Mullvad Leta 🎉
Mullvad Leta is the meta search engine service provided by the Mullvad.
💬 Additional Comments 💬
The service is only available when you are connected to Mullvad VPN, so I am not exactly sure if it is suitable for a userstyle here. I'm fine with either way, therefore I'll leave it to the staff to decide.
🗒 Checklist 🗒
/styles/<name-of-website>
containing the contents of the/template
directory.userstyles.yml
file with information about the new userstyle.
catppuccin.user.css
- all the CSS for the userstyle, based on thetemplate.
preview.webp
- composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.