Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mullvad-leta): init #1481

Merged
merged 7 commits into from
Jan 2, 2025
Merged

Conversation

jn-sena
Copy link
Member

@jn-sena jn-sena commented Dec 7, 2024

🎉 Theme for Mullvad Leta 🎉

Mullvad Leta is the meta search engine service provided by the Mullvad.

Catwalk of the home page
Catwalk of a result page

💬 Additional Comments 💬

The service is only available when you are connected to Mullvad VPN, so I am not exactly sure if it is suitable for a userstyle here. I'm fine with either way, therefore I'll leave it to the staff to decide.

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@jn-sena jn-sena requested a review from a team as a code owner December 7, 2024 13:10
Copy link
Member

@isabelroses isabelroses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but theres no way to test without a mullvad vpn account.

cc: @uncenter

Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good going by the preview image! Seeing as this is a relatively simple port and you are already a maintainer I think we can take you at your word that everything is themed :)

scripts/userstyles.yml Outdated Show resolved Hide resolved
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the logo in the center of the search page as seen in the preview screenshot themable as an SVG? https://github.com/catppuccin/userstyles/blob/main/docs/guide/images-and-svgs.md#img-elements

styles/mullvad-leta/catppuccin.user.less Outdated Show resolved Hide resolved
styles/mullvad-leta/catppuccin.user.less Outdated Show resolved Hide resolved
@uncenter uncenter added the waiting on author Note for staff that a re-review is not yet required label Jan 2, 2025
@jn-sena
Copy link
Member Author

jn-sena commented Jan 2, 2025

catwalk
results

After checking the Brave Search and SearXNG styles, I've changed the link colors to blue. Also colored the anchor links in FAQ and the line in the footer.

image

@jn-sena jn-sena requested a review from uncenter January 2, 2025 18:59
@uncenter
Copy link
Member

uncenter commented Jan 2, 2025

If possible can we avoid autogenerated classnames like a.svelte-14y20xk for the anchors? Any other attributes we can target there? A sibling selector? Just seems easy to break.

I've changed the link colors to blue

What color are the links on hover and what color are visited links?

@jn-sena
Copy link
Member Author

jn-sena commented Jan 2, 2025

What color are the links on hover and what color are visited links?

They're all the same, they use underline decoration for hover and nothing for visited links.

@uncenter uncenter removed the waiting on author Note for staff that a re-review is not yet required label Jan 2, 2025
Copy link
Member

@uncenter uncenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@uncenter uncenter requested a review from isabelroses January 2, 2025 22:53
@isabelroses isabelroses merged commit 9285821 into catppuccin:main Jan 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants