Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hackage): color the synopsis toggle and older Haddock pages #1418

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

jn-sena
Copy link
Member

@jn-sena jn-sena commented Nov 3, 2024

🔧 What does this fix? 🔧

  • Colored the MathJax renders using proper filters instead of fully inverting the color.
  • Fixed the synopsis toggle in Haddock using filters too.

the synopsis toggle before the change
the synopsis toggle after the change

  • Themed older Haddock pages (example) and sources.

old Haddock page before the change
old Haddock page after the change

🗒 Checklist 🗒

  • I have read and followed Catppuccin's contributing guidelines.
  • I have updated the version appropriately in the ==UserStyle== header of the catppuccin.user.css file.

@github-actions github-actions bot added the hackage Hackage label Nov 3, 2024
@jn-sena jn-sena merged commit 8acd305 into catppuccin:main Nov 4, 2024
3 checks passed
color: transparent;
summary,
#control\.syn {
filter: @synopsis-filter;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What color is this @synopsis-filter supposed to be?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surface0 as the background, though it also changes the text similar to just inverting it so it's not ideal. I think that was why I didn't name it @surface0-filter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is it not truly a surface0 filter then? Can you link me the page you can find this element on and maybe we can use an SVG approach or similar? I would like to move away from any nonstandard filters in #1547 now that we have https://github.com/catppuccin/userstyles/blob/main/docs/guide/images-and-svgs.md#non-svg-images-or-many-img-elements-with-external-svgs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's in every Haddock page, so here is an example one.

They use a png for that which is available here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hackage Hackage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants