Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gitlab): init #1337

Draft
wants to merge 56 commits into
base: main
Choose a base branch
from

Conversation

Thomas-Philippot
Copy link
Contributor

🎉 Theme for Gitlab 🎉

Gitlab is a online service to manage git repos with devops tools

💬 Additional Comments 💬

🗒 Checklist 🗒

  • I have read and followed Catppuccin's submission guidelines.
  • I have made a new directory underneath /styles/<name-of-website> containing the contents of the /template directory.
    • I have ensured that the new directory is in lower-kebab-case.
    • I have followed the template and kept the preprocessor as LESS.
  • I have made sure to update the
    userstyles.yml
    file with information about the new userstyle.
  • I have included the following files:
    • catppuccin.user.css - all the CSS for the userstyle, based on the
      template.
    • preview.webp - composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.

@Thomas-Philippot Thomas-Philippot requested review from a team and uncenter as code owners September 24, 2024 16:20
@github-actions github-actions bot added the github GitHub label Sep 24, 2024
Thomas Philippot added 2 commits September 24, 2024 18:23
scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
scripts/userstyles.yml Outdated Show resolved Hide resolved
@uncenter
Copy link
Member

Please be using https://github.com/catppuccin/userstyles/blob/main/template/catppuccin.user.css as the template as well. The example.org userstyle is not meant to be a template.

@uncenter uncenter marked this pull request as draft September 24, 2024 16:27
@uncenter
Copy link
Member

Lot of things still unthemed, please mark it as ready when you have fully themed the entire application - settings menus, modals, dropdown/selects/inputs, profile pages, READMEs, etc. A good trick is to use GitLab dark mode, but set the Catppuccin flavor to latte. Very easy to spot unthemed areas.

@Thomas-Philippot
Copy link
Contributor Author

Yes, still a couple of things to work on.
I just started working on this today, I'm making the pr to save my work, and mark this as work in progress

styles/github/README.md Outdated Show resolved Hide resolved
@thelooter
Copy link

I'm happy to help with this userstyle too if necessary

@Thomas-Philippot
Copy link
Contributor Author

I'm happy to help with this userstyle too if necessary

I will be more than happy to have some help, how can we manage this ?

@thelooter
Copy link

I'm happy to help with this userstyle too if necessary

I will be more than happy to have some help, how can we manage this ?

Are you in the discord server? Communicating there could make things a bit easier

@github-actions github-actions bot removed the github GitHub label Sep 25, 2024
@Thomas-Philippot
Copy link
Contributor Author

Sorry for the mass review requests, I just wanted to update the branch

@comfysage
Copy link
Contributor

Sorry for the mass review requests, I just wanted to update the branch

the review requests got triggered because you pushed changes to other userstyles. you probably accidentally added some formatting changes. you should be able to revert the commit and uncommit the changes.

@github-actions github-actions bot removed twitch Twitch duckduckgo DuckDuckGo google-photos Google Photos listenbrainz ListenBrainz labels Dec 30, 2024
@Thomas-Philippot Thomas-Philippot removed the request for review from stellophiliac December 30, 2024 12:07
@github-actions github-actions bot removed the amplenote Amplenote label Dec 30, 2024
@comfysage
Copy link
Contributor

do you want to convert this to a draft and work on it further?
you'll be able to convert it to a full pr and request a review when you feel it's ready <3

@uncenter
Copy link
Member

uncenter commented Jan 2, 2025

Going to mark this as a draft as mentioned to spare some notifications and more clearly signal the work that needs to be done :) thanks again for your continued work on this @Thomas-Philippot, excited for this to be added!

@uncenter uncenter marked this pull request as draft January 2, 2025 12:36
@uncenter uncenter removed the waiting on author Note for staff that a re-review is not yet required label Jan 2, 2025
@thelooter
Copy link

image
Merge Request approval widget has unreadable header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants