Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modules): expose palette in config.lib #97

Closed

Conversation

Anomalocaridid
Copy link
Contributor

Exposes palettes to config.lib in both NixOS and Home Manager modules. Closes #96.

I essentially took palette.json from catppuccin/palette and converted it into an attrset, config.lib.catppuccin.palettes. I also made it so the palette corresponding to the user's set flavor would be exposed by itself as config.lib.catppuccin.palette. In the home manager module, the latter also has an extra attribute that corresponds to the user's set accent color for convenience.

@getchoo
Copy link
Member

getchoo commented Apr 18, 2024

sorry for the wait, but i wanted to explore some alternatives before really getting into this

i don't think exposing config.lib is the best way to go here, or only exposing the palette itself. most of my thoughts are still summed in #96 (comment), but to get more technical: sources should probably be a global option that's a name value pair of the source name and it's path in the store. this would allow for any source to be reused or changed fairly easily, and still be similar to how sources is an argument for our modules now. i have my own branch with this idea that i will be PRing soon, but it also will (probably) require a switch to npins from nvfetcher, which is something i'd like to handle myself

thanks for your work here though, i genuinely appreciate it :)

@getchoo getchoo closed this Apr 18, 2024
@Anomalocaridid
Copy link
Contributor Author

No worries. Honestly, that does seem like a much better and more general approach.

@Anomalocaridid Anomalocaridid deleted the expose-palette branch April 18, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expose palette to lib
2 participants