Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(home-manager/hyprland): source theme + accent #80

Merged
merged 3 commits into from
May 8, 2024

Conversation

Liassica
Copy link
Contributor

@Liassica Liassica commented Feb 8, 2024

Since Home Manager defbb9c, Hyprland on Home Manager now sources files before most other configuration, meaning ctp-nix can now source a theme colors file instead of inserting them into the main configuration. In addition, accent and accentAlpha color variables have been added in a second sourced file.

@Anomalocaridid
Copy link
Contributor

If files are sourced first, would it be possible to implement an accent option that sets Hyprland variables named something like $accent and $accentAlpha to the corresponding variables for your accent color?

For example, if your accent is red, would the below lines work if the module added them to your Hyprland config?

$accent=$red
$accentAlpha=$redAlpha

@Liassica Liassica changed the title fix(home-manager/hyprland): source theme colors feat(home-manager/hyprland): source theme + accent Feb 10, 2024
@Liassica
Copy link
Contributor Author

Added that. Currently it's implemented as a second sourced file, as variables are one of the only configuration that gets placed before source entries, so they can't just be added with hyprland.settings.

modules/home-manager/hyprland.nix Outdated Show resolved Hide resolved
@Liassica Liassica force-pushed the hyprland-fix branch 2 times, most recently from 7d0d3cf to 238a056 Compare March 17, 2024 18:09
@getchoo
Copy link
Member

getchoo commented Apr 10, 2024

sorry for the wait! it seems this branch has fallen a bit behind and is still stuck with a bug that's been fixed; could this be rebased?

Since Home Manager defbb9c, Hyprland on Home Manager now sources files
before most other configuration, meaning Catppuccin Nix can now source a
theme colors file instead of inserting them into the main configuration.
In addition, `accent` and `accentAlpha` color variables have been added
in a second sourced file.
@Liassica
Copy link
Contributor Author

Done! I also updated the commit description a bit since this is an official Catppuccin repository now.

Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so sorry for the long wait. thanks so much!

@getchoo getchoo merged commit cab752b into catppuccin:main May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants