Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(home-manager/cursors): automatically enable cursor for gtk and x11 #276

Closed
wants to merge 1 commit into from
Closed

Conversation

PerchunPak
Copy link
Contributor

@PerchunPak PerchunPak commented Jul 4, 2024

Otherwise, home.pointerCursor is useless I suppose

EDIT: Not entirely useless (see https://github.com/nix-community/home-manager/blob/0a30138c694ab3b048ac300794c2eb599dc40266/modules/config/home-cursor.nix#L165), but still it didn't work for me on GNOME

@isabelroses
Copy link
Member

Personally I think this would be better as an assertion, it its added at all. Perhaps this should assert that at least one of these are set to true?

@Weathercold
Copy link
Contributor

An assertion doesn’t make sense because home.pointerCursor is effective by itself, and some people might want to leave the extra options disabled. I suggest we either don’t set them or set them with mkDefault

@getchoo
Copy link
Member

getchoo commented Jul 7, 2024

unlike some other places where we assert or enable options, this is simply changing the defaults of the parent module that we don't actually require. suggestions like this would probably be better made in the upstream module, as this is not specific to us and i would consider this intended behavior at it stands. thanks though :)

@getchoo getchoo closed this Jul 7, 2024
@PerchunPak PerchunPak deleted the patch-1 branch July 7, 2024 00:38
@PerchunPak
Copy link
Contributor Author

Maybe we should add a note/warning in docs to let users know that they should enable those options in some cases in order to make cursor work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants