Skip to content

fix(auth): skip Kratos login when a session already exists during OAuth #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cativo23 merged 1 commit into from
Jun 23, 2026
Merged

fix(auth): skip Kratos login when a session already exists during OAuth #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion frontend-auth/src/views/Login.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ import { useRouter, useRoute } from 'vue-router'
import type { LocationQuery, LocationQueryValue } from 'vue-router'
import type { UpdateLoginFlowBody } from '@ory/client'
import NovaLogoIcon from '../components/NovaLogoIcon.vue'
import { createLoginFlow, getLoginFlow, updateLoginFlow } from '../composables/useAuth'
import { checkSession, createLoginFlow, getLoginFlow, updateLoginFlow } from '../composables/useAuth'
import type { FlowLike, HttpErrorLike, ContinueWithLike } from '../types/flow'
import type { UiNodeLike } from '../utils/uiNodes'
import { logger, errMessage } from '../utils/logger'
Expand Down Expand Up @@ -282,6 +282,16 @@ onMounted(async () => {
// OAuth/Hydra flow: after Kratos login, land on hydra-callback to accept Hydra login and complete OAuth
const base = import.meta.env.VITE_AUTH_URL || window.location.origin
const returnUrl = `${base}/auth/hydra-callback?login_challenge=${encodeURIComponent(loginChallenge)}`
// If a Kratos session already exists, creating a new login flow would make
// Kratos reject with 400 "you are already logged in" and dump the user on
// the generic error page. Skip Kratos login entirely and go straight to
// hydra-callback, which accepts the Hydra login via the BFF using the
// existing session cookie (honoring Hydra's `skip`).
const existingSession = await checkSession().catch(() => null)
if (existingSession) {
window.location.href = returnUrl
return
}
intendedReturnUrl.value = returnUrl
flow.value = await createLoginFlow(returnUrl)
} else {
Expand Down
Loading