Repository navigation
release: v1.0.0-alpha.23 - #55
Merged
Merged
Conversation
release: v1.0.0-alpha.22
…ction crash Every PDF analysis in production failed with "Setting up fake worker failed: Cannot find module '.../pdfjs-dist/legacy/build/pdf.worker.mjs'" (discovered live during plan 13-04's LAUNCH-01 end-to-end verification). Same root cause class as the @napi-rs/canvas fix in 13-01: pdfjs-dist resolves its worker script by path at runtime rather than through a static import/require, so Nitro's node-file-trace never follows it and silently omits it from .output. Rather than cherry-picking individual missing files as the tracer's gaps in this package keep surfacing one at a time, replace the whole traced (partial) pdfjs-dist directory with the real, complete package copied straight from the deps stage. Verified locally: built the image with this fix and ran pdf-parse's actual PDFParse().getText() against the repo's test fixture PDF inside the container — extracted 8969 characters (previously threw MODULE_NOT_FOUND / fake-worker-setup failure).
fix(deploy): copy full pdfjs-dist to fix PDF extraction crash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
Deploy notes
Third same-day hotfix, following v1.0.0-alpha.20/21/22.