Repository navigation
release: v1.0.0-alpha.22 - #52
Merged
Merged
Conversation
release: v1.0.0-alpha.21
…ismatch dead clicks The header's guest-nav login link (and the two homepage CTA login links) sit inside a v-if/v-else pair keyed on useSupabaseUser()'s user ref. If the client's initial reactive value of `user` differs even briefly from what SSR rendered (a timing artifact of the Supabase session check resolving asynchronously on the client, vs. synchronously during SSR), Vue detects a hydration mismatch on that whole nav subtree and discards + remounts it. Until that remount lands, the server-rendered anchor is visually present but carries no Vue Router click binding — a click in that window is silently swallowed (confirmed via a raw document-level click listener: zero events reached the DOM at all for the affected clicks, while unrelated buttons elsewhere on the page kept working). Reproduced this live against production: identical coordinate clicks on the same link succeeded roughly half the time, uncorrelated with how long the page had been loaded — consistent with a race against an async remount rather than a fixed hydration delay. Rather than reworking useSupabaseUser()'s SSR/client parity (a much larger, riskier change touching every user-gated element on the site), marks these three /login NuxtLinks `external`, so Nuxt renders them as plain anchors outside Vue Router's client-side interception. A plain anchor is clickable the instant it's painted, regardless of hydration state — it can't go inert.
fix(ui): force native navigation on login links (dead-click bug)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
Deploy notes
Same-day follow-up hotfix after v1.0.0-alpha.21.