-
Notifications
You must be signed in to change notification settings - Fork 31
Subplugin and Course Custom fields #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: MOODLE_404_STABLE
Are you sure you want to change the base?
Subplugin and Course Custom fields #240
Conversation
DEF-3115: Adding custom course fields test
DEF-3115: Adding testing for subplugins
DEF-3115: Fixing pipeline
hi @ojnadjarm Thanks for this PR. I like the idea and this 100% will make the plugin more flexible. In our plugins we started to go away from subplugins structure as it's not necessary in most of the cases as well as it reduces an amount of boilerplate code around subplugins (like version, lang strings, privacy and etc). Instead we either use hooks/callback to get appropriate classes from other plugins (so we expect a plugin to implement a callback in lib.php or subscribe to a custom hook and provide implementation of specific classes) or just discover appropriate classes from all auto-loaded classes (which is easier IMHO), See an example of latter here https://github.com/catalyst/moodle-tool_dynamic_cohorts?tab=readme-ov-file#technical-details -> https://github.com/catalyst/moodle-tool_dynamic_cohorts/blob/MOODLE_404_STABLE/classes/condition_manager.php#L39 Wouldn't you mind to rework your code using the same approach + document it all in README of the plugin? |
@ojnadjarm also would be nice to split this PR into two - one for course fields and the second one for "subplugins". Thanks in advance. Issue for course custom fields #104 Issue for "subplugin" extension #243 |
This PR add the posibility to add custom subplugins on the custom folder. That way ppl can generate it's own steps, without modifying the plugin, also the custom course field are now supported.