Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinearGradient start & end property array deprecation warning #5

Merged
merged 3 commits into from
Nov 8, 2019

Conversation

catalinmiron
Copy link
Owner

Hi catalinmiron,

A big thanks for creating this library.

I've set it up to use with the react-native-linear-gradient ( 2.5.4 ) library. In this setup, I get the following warnings ( screenshot ):

Screen Shot 2019-06-10 at 4 39 21 pm

I'm not sure if this shows in Expo. The fix, however, is trivial.

    start: { x:center.x - xDiff, y:center.y - yDiff },
    end: { x:center.x + xDiff, y:center.y + yDiff }

Happy to send a PR if this fix doesn't break Expo.

Thanks

@catalinmiron
Copy link
Owner

I'm going to refactor this :)

@catalinmiron catalinmiron merged commit c2869d0 into master Nov 8, 2019
@catalinmiron catalinmiron deleted the 5-refactor-css-gradient branch November 8, 2019 10:57
@catalinmiron
Copy link
Owner

Published
react-native-css-gradient 0.4.0 published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant