Prevent leaking stacktrace when unable to parse URI query params #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squarejesse
approved these changes
Mar 7, 2025
JGulbronson
force-pushed
the
jgulbronson.prevent-leaking-stacktrace
branch
from
500e37e to
e886695
Compare
adrw
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When calling
JettyWebSocketServlet.service, Jetty can throw when trying to extract the query params. This is a known issue, and results in a stacktrace being sent in the response. Sending the stacktrace by default seems like an unwanted behavior from a security perspective, so I'd made a change that preserves the status code and message, but removes the stacktrace to avoid leaking unwanted information. I didn't feel it was necessary to add a flag for this toWebConfigbecause in almost all cases I believe this to be the behavior that users would want.