do not render items if the react list is hidden #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some columns on the same page that uses react-list. In each one I have 200 items. Seven are visible in the portview, and 13 are rendered, I load more on scroll.
When I open a column item in fullwidth, all the other columns are hidden (display: 'none';). Here my problem started with react-list.
The viewport of those columns was 0 (they are hidden, remember?). and some how react-list started to render all the 200 items for every column.
The
endwas getting bigger and bigger from the threshold (let end = scroll + this.getViewportSize() + threshold;. react list was rendering more items are soon as there was more space)This caused big performance issues in my app. What I've tried to achieve here is to stop react list on rendering items when it is hidden (display: 'none';).