Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W.I.P]refactor: refactored the model section code #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rishabhmodii
Copy link
Contributor

Refactored the code in model Section to follow the Golang Casbin's naming function

@casbin-bot
Copy link
Member

@tangyang9464 @closetool @sagilio please review

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2022

CLA assistant check
All committers have signed the CLA.

@Rishabhmodii Rishabhmodii changed the title refactor: refactored the model section code [W.I.P]refactor: refactored the model section code Jul 9, 2022
@hsluoyz
Copy link
Member

hsluoyz commented Jul 10, 2022

@Rishabhmodii plz sign CLA:

image

@hsluoyz
Copy link
Member

hsluoyz commented Jul 11, 2022

@MrUnfunny @xiaobeiswift plz review

@@ -65,7 +65,7 @@ class Assertion {

Copy link
Contributor

@MrUnfunny MrUnfunny Jul 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rishabhmodii add a copywith to assertion class, similar to copy function of go version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants