feat: change mut ref to ref in the parameters of get_roles_for_user and other similar functions.

src/enforcer.rs

@@ -628,7 +628,6 @@ impl CoreApi for Enforcer {
     /// #[cfg(all(not(feature = "runtime-async-std"), not(feature = "runtime-tokio")))]
     /// fn main() {}
     /// ```
-
     fn enforce_with_context<ARGS: EnforceArgs>(
         &self,
         ctx: EnforceContext,

src/rbac_api.rs

@@ -66,7 +66,7 @@
     }
 
     fn get_roles_for_user(
-        &mut self,
+        &self,
         name: &str,
         domain: Option<&str>,
     ) -> Vec<String>;
@@ -76,7 +76,7 @@
         domain: Option<&str>,
     ) -> Vec<String>;
     fn has_role_for_user(
-        &mut self,
+        &self,
         name: &str,
         role: &str,
         domain: Option<&str>,
@@ -92,12 +92,12 @@
         permission: Vec<String>,
     ) -> bool;
     fn get_implicit_roles_for_user(
-        &mut self,
+        &self,
         name: &str,
         domain: Option<&str>,
     ) -> Vec<String>;
     fn get_implicit_permissions_for_user(
-        &mut self,
+        &self,
         name: &str,
         domain: Option<&str>,
     ) -> Vec<Vec<String>>;
@@ -212,14 +212,14 @@
     }
 
     fn get_roles_for_user(
-        &mut self,
+        &self,
         name: &str,
         domain: Option<&str>,
     ) -> Vec<String> {
         let mut roles = vec![];
-        if let Some(t1) = self.get_mut_model().get_mut_model().get_mut("g") {
-            if let Some(t2) = t1.get_mut("g") {
-                roles = t2.rm.write().get_roles(name, domain);
+        if let Some(t1) = self.get_model().get_model().get("g") {
+            if let Some(t2) = t1.get("g") {
+                roles = t2.rm.read().get_roles(name, domain);
             }
         }
 
@@ -240,7 +240,7 @@
     }
 
     fn has_role_for_user(
-        &mut self,
+        &self,
         name: &str,
         role: &str,
         domain: Option<&str>,
@@ -311,16 +311,15 @@
     }
 
     fn get_implicit_roles_for_user(
-        &mut self,
+        &self,
         name: &str,
         domain: Option<&str>,
     ) -> Vec<String> {
         let mut res: HashSet<String> = HashSet::new();
         let mut q: Vec<String> = vec![name.to_owned()];
         while !q.is_empty() {
             let name = q.swap_remove(0);
-            let roles =
-                self.get_role_manager().write().get_roles(&name, domain);
+            let roles = self.get_role_manager().read().get_roles(&name, domain);
             for r in roles.into_iter() {
                 if res.insert(r.to_owned()) {
                     q.push(r);
@@ -331,7 +330,7 @@
     }
 
     fn get_implicit_permissions_for_user(
-        &mut self,
+        &self,
         user: &str,
         domain: Option<&str>,
     ) -> Vec<Vec<String>> {
@@ -908,7 +907,7 @@
 
         let adapter =
             FileAdapter::new("examples/rbac_with_hierarchy_policy.csv");
         let mut e = Enforcer::new(m, adapter).await.unwrap();
 
         assert_eq!(
             vec![vec!["alice", "data1", "read"]],
@@ -945,7 +944,7 @@
 
         let adapter =
             FileAdapter::new("examples/rbac_with_hierarchy_policy.csv");
         let mut e = Enforcer::new(m, adapter).await.unwrap();
 
         assert_eq!(
             vec![vec!["alice", "data1", "read"]],
@@ -1052,7 +1051,7 @@
         let adapter = FileAdapter::new(
             "examples/rbac_with_hierarchy_with_domains_policy.csv",
         );
         let mut e = Enforcer::new(m, adapter).await.unwrap();
 
         assert_eq!(
             vec![
@@ -1076,7 +1075,7 @@
         tokio::test
     )]
     async fn test_pattern_matching_fn() {
         let mut e = Enforcer::new(
             "examples/rbac_with_pattern_model.conf",
             "examples/rbac_with_pattern_policy.csv",
         )
@@ -1121,7 +1120,7 @@
         tokio::test
     )]
     async fn test_pattern_matching_fn_with_domain() {
         let mut e = Enforcer::new(
             "examples/rbac_with_pattern_domain_model.conf",
             "examples/rbac_with_pattern_domain_policy.csv",
         )
@@ -1165,7 +1164,7 @@
         tokio::test
     )]
     async fn test_pattern_matching_basic_role() {
         let mut e = Enforcer::new(
             "examples/rbac_basic_role_model.conf",
             "examples/rbac_basic_role_policy.csv",
         )