feat: add StringAdapter to file adapter module #343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsluoyz
requested changes
Oct 6, 2024
| pub use adapter::{Adapter, Filter, MemoryAdapter, NullAdapter}; | ||
| #[cfg(not(target_arch = "wasm32"))] | ||
| pub use adapter::{FileAdapter, StringAdapter}; | ||
|
|
||
| #[cfg(feature = "cached")] |
| pub use adapter::{Adapter, Filter, MemoryAdapter, NullAdapter}; | ||
| #[cfg(not(target_arch = "wasm32"))] |
| @@ -290,3 +290,160 @@ fn load_filtered_policy_line( | |||
| false | |||
| } | |||
| } | |||
|
|
|||
| pub struct StringAdapter { | |||
Benchmark for c5a05d3Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
StringAdapterto handle policy strings directly, along with necessary integrations and updates to the existing codebase. The most important changes include the addition of theStringAdapterstruct and its implementation, updates to theadaptermodule to include the new adapter, and modifications to the main library file to use the new adapter.Introduction of
StringAdapter:src/adapter/file_adapter.rs: Added theStringAdapterstruct with methods to load, save, and clear policies from a string, and implemented theAdaptertrait for it.Module updates:
src/adapter/mod.rs: Updated to includeStringAdapterin the list of exported adapters.Library updates:
src/lib.rs: Modified to conditionally exportStringAdapteralong with other adapters.