Builds perfectly on windows (Visual studio code) and added Makefile(make). #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hsluoyz you can review the code and pull the commits. |
xcaptain
reviewed
Mar 6, 2020
|
@hsluoyz can review and merge it? |
|
Please rework/rebase/replace the wrong commits. Not appending more commits after wrong commits.
|
Casbin assets added. Placeholder folders added.
Role manager abstract class(interface) added. Changes in include directives. Made necessary changes Removed .github folder.
DefaultRoleManager added. Removed unnecessary includeFiles. Made changes in ordered to unorder_map, enum to enum-class and declaring iterators inside for loop. h to hpp
|
Have squashed the commits to the important ones, now you can merge it. |
|
Make your code compile on Visual Studio. |
|
I have made a Makefile and the codebase builds perfectly on my system(Windows Visual Studio Code.) |
|
@hsluoyz can you please confirm it on your working environment and let me know if any changes to be made on my side or feel free to change. |
divy9881
changed the title
|
Base your code on our latest master branch, follow our folder structure, filename naming, etc. |
|
Yeah, already done and also following Google CPP code style guide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.