feat: Add no-subscribe-in-pipe rule to forbid calling subscribe within pipe operators
#131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed plugin to rxjs-x in docs, readme, config, etc. - Reset version to 0.0.0. - Updated LICENSE, CHANGELOG, package.json for fork. - Updated Rules in README to be more comprehensive. - Replaced circleci config with GitHub Actions ci. - Removed precommit hook, prettier, FUNDING. - Added auto-fix to vs code settings.
BREAKING CHANGES: eslint v9, tseslint v8, node engines same as eslint. - Replaced experimental-utils with utils. - Fixed identifier type error in ban-observables and ban-operators. - Fixed breaking change to AST in no-explicit-generics. - Added direct dependency on scope-manager. - Installed ESLint v9, rewrote config, and ran auto-fix. - Removed build steps for now. - Removed etc getParent and getParserServices as unnecessary. - Use shortcut getTypeAtLocation in getType helper. - Changed all rules to a named export. - Converted tests to vitest and fixed all. - Fixed missing suggestions in no-implicit-any-catch tests. - Rewrote prefer-observer tests to avoid lots of duplicated suggestions. - recommended doc is now a boolean instead of "error". - Added RxJS to peerDependencies.
- Also removed fixable and hasSuggestions when they're defaulted to false/undefined.
- Fix types in package.json causing package to masquerade as ESM - Change the default export to be a more helpful name to avoid import-x/no-rename-default. - Fix incorrect default export in CJS due to a known issue with unbuild.
- Remove unmaintained `tsutils` and `tsutils-etc`. - `tsutils` has been replaced by the community with `ts-api-utils`. See ajafff/tsutils#145. Replacing it was fairly simple. - `tsutils-etc` relies on `tsutils`, and I haven't seen a community-chosen replacement, so we're re-implementing the utilities into this repo, similar to how we re-implemented `eslint-etc` utilities. So utilities now exist in `ts-api-utils`, but `couldBeType` and `couldBeFunction` had to be ported over. - Pull in a dev dependency on `@typescript/vfs` to unit test `couldBeType` based on the `tsutils-etc` unit tests for that function. - Bump the minimum versions of TypeScript to >=4.2.0 to align with `ts-api-utils` and `tslib` to ^2.1.0 to align with `rxjs`.
- Change package.json type to CJS for more compatibility.
- Replace `unbuild` with `tsup` for more default export ergonomics.
- `unbuild` was fine as long as we added a patch script to export
`default` in CJS. However that's a bit unexpected in CJS; you would
expect to just do `const rxjsX = require('eslint-plugin-rxjs-x');`
without `.default` tacked onto the end. `tsup` lets us build different
output for CJS that's more ergonomic for CJS users.
- Had to remove the `assert { type: 'json' }` since `esbuild` doesn't
support it combined with named exports.
- Only support decamelize v5.
- v6 is ESM-only, which would be fine if users use this plugin in an ESM
eslint config. However if they're using a CJS eslint config and they
install this package, their package manager will likely pull in
decamelize v6 and cause a error trying to import it. Downgrading helps
avoid that confusion; advanced users who need v6 can use something like
yarn resolutions to override.
- Add eslint-doc-generator and run on existing documentation. - Update existing rule descriptions to align across both rule description and markdown header. - Add Configs section to README. - Add markdownlint.
…tant#45) Bumps the typescript-eslint group with 2 updates: [@typescript-eslint/rule-tester](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/rule-tester) and [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint). Updates `@typescript-eslint/rule-tester` from 8.14.0 to 8.15.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/rule-tester</code>'s releases</a>.</em></p> <blockquote> <h2>v8.15.0</h2> <h2>8.15.0 (2024-11-18)</h2> <h3>🚀 Features</h3> <ul> <li><strong>eslint-plugin:</strong> added related-getter-setter-pairs rule (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10192">#10192</a>)</li> <li><strong>eslint-plugin:</strong> new rule <code>no-unsafe-type-assertion</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10051">#10051</a>)</li> <li><strong>eslint-plugin:</strong> [prefer-nullish-coalescing] fix detection of <code>ignoreConditionalTests</code> involving boolean <code>!</code> operator (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10299">#10299</a>)</li> <li><strong>rule-tester:</strong> run method - avoid to infer type parameter from <code>tests</code> param (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10324">#10324</a>)</li> <li><strong>typescript-eslint:</strong> allow infinitely deep array nesting in config function and extends (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10333">#10333</a>)</li> <li><strong>utils:</strong> add new optional <code>language</code> field to <code>FlatConfig.Config</code> type (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10326">#10326</a>)</li> </ul> <h3>🩹 Fixes</h3> <ul> <li>add missing peer dependencies (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/9744">#9744</a>)</li> <li><strong>eslint-plugin:</strong> [consistent-indexed-object-style] handle circular mapped types (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10301">#10301</a>)</li> <li><strong>eslint-plugin:</strong> [await-thenable, return-await] don't flag awaiting unconstrained type parameter as unnecessary (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10314">#10314</a>)</li> <li><strong>eslint-plugin:</strong> [explicit-module-boundary-types] and [explicit-function-return-type] don't report on <code>as const satisfies</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10315">#10315</a>)</li> <li><strong>eslint-plugin:</strong> report deprecations used in default export (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10330">#10330</a>)</li> <li><strong>utils:</strong> add defaultOptions to meta in rule (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10339">#10339</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Bartosz <a href="https://github.com/burtek"><code>@burtek</code></a></li> <li>Brad Zacher <a href="https://github.com/bradzacher"><code>@bradzacher</code></a></li> <li>Ethan Wu</li> <li>Josh Goldberg ✨</li> <li>Kim Sang Du <a href="https://github.com/developer-bandi"><code>@developer-bandi</code></a></li> <li>Luis Sebastian Urrutia Fuentes <a href="https://github.com/LuisUrrutia"><code>@LuisUrrutia</code></a></li> <li>Marco Pasqualetti <a href="https://github.com/marcalexiei"><code>@marcalexiei</code></a></li> <li>Phillip Huang</li> <li>Ronen Amiel</li> <li>Szydlak <a href="https://github.com/wszydlak"><code>@wszydlak</code></a></li> </ul> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/rule-tester/CHANGELOG.md"><code>@typescript-eslint/rule-tester</code>'s changelog</a>.</em></p> <blockquote> <h2>8.15.0 (2024-11-18)</h2> <h3>🚀 Features</h3> <ul> <li><strong>rule-tester:</strong> run method - avoid to infer type parameter from <code>tests</code> param (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10324">#10324</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Marco Pasqualetti <a href="https://github.com/marcalexiei"><code>@marcalexiei</code></a></li> </ul> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/244435126619afb9497ace04cbf4819012e27330"><code>2444351</code></a> chore(release): publish 8.15.0</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/6c27d08f2f5eca126d22c1e3cd0b9c38644c76ef"><code>6c27d08</code></a> chore: bump eslint dependencies (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/rule-tester/issues/10354">#10354</a>)</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/0f9a2a3310dc0d69562a9ff1ad897f62201a7663"><code>0f9a2a3</code></a> feat(rule-tester): run method - avoid to infer type parameter from <code>tests</code> pa...</li> <li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v8.15.0/packages/rule-tester">compare view</a></li> </ul> </details> <br /> Updates `typescript-eslint` from 8.14.0 to 8.15.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases">typescript-eslint's releases</a>.</em></p> <blockquote> <h2>v8.15.0</h2> <h2>8.15.0 (2024-11-18)</h2> <h3>🚀 Features</h3> <ul> <li><strong>eslint-plugin:</strong> added related-getter-setter-pairs rule (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10192">#10192</a>)</li> <li><strong>eslint-plugin:</strong> new rule <code>no-unsafe-type-assertion</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10051">#10051</a>)</li> <li><strong>eslint-plugin:</strong> [prefer-nullish-coalescing] fix detection of <code>ignoreConditionalTests</code> involving boolean <code>!</code> operator (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10299">#10299</a>)</li> <li><strong>rule-tester:</strong> run method - avoid to infer type parameter from <code>tests</code> param (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10324">#10324</a>)</li> <li><strong>typescript-eslint:</strong> allow infinitely deep array nesting in config function and extends (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10333">#10333</a>)</li> <li><strong>utils:</strong> add new optional <code>language</code> field to <code>FlatConfig.Config</code> type (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10326">#10326</a>)</li> </ul> <h3>🩹 Fixes</h3> <ul> <li>add missing peer dependencies (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/9744">#9744</a>)</li> <li><strong>eslint-plugin:</strong> [consistent-indexed-object-style] handle circular mapped types (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10301">#10301</a>)</li> <li><strong>eslint-plugin:</strong> [await-thenable, return-await] don't flag awaiting unconstrained type parameter as unnecessary (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10314">#10314</a>)</li> <li><strong>eslint-plugin:</strong> [explicit-module-boundary-types] and [explicit-function-return-type] don't report on <code>as const satisfies</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10315">#10315</a>)</li> <li><strong>eslint-plugin:</strong> report deprecations used in default export (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10330">#10330</a>)</li> <li><strong>utils:</strong> add defaultOptions to meta in rule (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10339">#10339</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Bartosz <a href="https://github.com/burtek"><code>@burtek</code></a></li> <li>Brad Zacher <a href="https://github.com/bradzacher"><code>@bradzacher</code></a></li> <li>Ethan Wu</li> <li>Josh Goldberg ✨</li> <li>Kim Sang Du <a href="https://github.com/developer-bandi"><code>@developer-bandi</code></a></li> <li>Luis Sebastian Urrutia Fuentes <a href="https://github.com/LuisUrrutia"><code>@LuisUrrutia</code></a></li> <li>Marco Pasqualetti <a href="https://github.com/marcalexiei"><code>@marcalexiei</code></a></li> <li>Phillip Huang</li> <li>Ronen Amiel</li> <li>Szydlak <a href="https://github.com/wszydlak"><code>@wszydlak</code></a></li> </ul> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md">typescript-eslint's changelog</a>.</em></p> <blockquote> <h2>8.15.0 (2024-11-18)</h2> <h3>🚀 Features</h3> <ul> <li><strong>typescript-eslint:</strong> allow infinitely deep array nesting in config function and extends (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10333">#10333</a>)</li> <li><strong>eslint-plugin:</strong> new rule <code>no-unsafe-type-assertion</code> (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10051">#10051</a>)</li> <li><strong>eslint-plugin:</strong> added related-getter-setter-pairs rule (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/10192">#10192</a>)</li> </ul> <h3>🩹 Fixes</h3> <ul> <li>add missing peer dependencies (<a href="https://redirect.github.com/typescript-eslint/typescript-eslint/pull/9744">#9744</a>)</li> </ul> <h3>❤️ Thank You</h3> <ul> <li>Brad Zacher <a href="https://github.com/bradzacher"><code>@bradzacher</code></a></li> <li>Ethan Wu</li> <li>Josh Goldberg ✨</li> <li>Ronen Amiel</li> </ul> <p>You can read about our <a href="https://main--typescript-eslint.netlify.app/users/versioning">versioning strategy</a> and <a href="https://main--typescript-eslint.netlify.app/users/releases">releases</a> on our website.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/244435126619afb9497ace04cbf4819012e27330"><code>2444351</code></a> chore(release): publish 8.15.0</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/b351703a235e5896ba2c39cf0ef59c0b8c24e344"><code>b351703</code></a> feat(typescript-eslint): allow infinitely deep array nesting in config functi...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/00a3a84e40910b38c7d14c284e1fbc6528e9ad44"><code>00a3a84</code></a> fix: add missing peer dependencies (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint/issues/9744">#9744</a>)</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/9ebdff460047c3d688b48d0418b21e5aea0f481d"><code>9ebdff4</code></a> feat(eslint-plugin): new rule <code>no-unsafe-type-assertion</code> (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint/issues/10051">#10051</a>)</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/04098513a0307aa5d8b21a50ac82e5680d04a898"><code>0409851</code></a> feat(eslint-plugin): added related-getter-setter-pairs rule (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint/issues/10192">#10192</a>)</li> <li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v8.15.0/packages/typescript-eslint">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jason Weinzierl <[email protected]>
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.6.3 to 5.7.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/microsoft/TypeScript/releases">typescript's releases</a>.</em></p> <blockquote> <h2>TypeScript 5.7</h2> <p>For release notes, check out the <a href="https://devblogs.microsoft.com/typescript/announcing-typescript-5-7/">release announcement</a>.</p> <ul> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=milestone%3A%22TypeScript+5.7.0%22+is%3Aclosed+">fixed issues query for Typescript 5.7.0 (Beta)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=milestone%3A%22TypeScript+5.7.1%22+is%3Aclosed+">fixed issues query for Typescript 5.7.1 (RC)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=milestone%3A%22TypeScript+5.7.2%22+is%3Aclosed+">fixed issues query for Typescript 5.7.2 (Stable)</a>.</li> </ul> <p>Downloads are available on:</p> <ul> <li><a href="https://www.npmjs.com/package/typescript">npm</a></li> </ul> <h2>TypeScript 5.7 RC</h2> <p>For release notes, check out the <a href="https://devblogs.microsoft.com/typescript/announcing-typescript-5-7-rc/">release announcement</a>.</p> <p>For the complete list of fixed issues, check out the</p> <ul> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=milestone%3A%22TypeScript+5.7.0%22+is%3Aclosed+">fixed issues query for Typescript 5.7.0 (Beta)</a>.</li> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=milestone%3A%22TypeScript+5.7.1%22+is%3Aclosed+">fixed issues query for Typescript 5.7.1 (RC)</a>.</li> </ul> <p>Downloads are available on:</p> <ul> <li><a href="https://www.npmjs.com/package/typescript">npm</a></li> </ul> <h2>TypeScript 5.7 Beta</h2> <p>For release notes, check out the <a href="https://devblogs.microsoft.com/typescript/announcing-typescript-5-7-beta/">release announcement</a>.</p> <p>For the complete list of fixed issues, check out the</p> <ul> <li><a href="https://github.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93&q=milestone%3A%22TypeScript+5.7.0%22+is%3Aclosed+">fixed issues query for Typescript 5.7.0 (Beta)</a>.</li> </ul> <p>Downloads are available on:</p> <ul> <li><a href="https://www.npmjs.com/package/typescript">npm</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/TypeScript/commit/d701d908d534e68cfab24b6df15539014ac348a3"><code>d701d90</code></a> Bump version to 5.7.2 and LKG</li> <li><a href="https://github.com/microsoft/TypeScript/commit/0503a630fdc1478a63fe8bcb9bea2d6d927fcca4"><code>0503a63</code></a> 🤖 Pick PR <a href="https://redirect.github.com/microsoft/TypeScript/issues/60450">#60450</a> (Move to file: fix detection of refe...) into release-5.7 (#...</li> <li><a href="https://github.com/microsoft/TypeScript/commit/3140dbb79a42897eeebbc357a5a78e409b429323"><code>3140dbb</code></a> 🤖 Pick PR <a href="https://redirect.github.com/microsoft/TypeScript/issues/60488">#60488</a> (Stub out copilotRelated command) into release-5.7 (<a href="https://redirect.github.com/microsoft/TypeScript/issues/60495">#60495</a>)</li> <li><a href="https://github.com/microsoft/TypeScript/commit/c1216dea1a504da7b89b5221b925abcd1702d7e4"><code>c1216de</code></a> Update LKG</li> <li><a href="https://github.com/microsoft/TypeScript/commit/3ee2b95689943c720d47db01b4a1da2b6ab9d9ff"><code>3ee2b95</code></a> 🤖 Pick PR <a href="https://redirect.github.com/microsoft/TypeScript/issues/60415">#60415</a> (Fix false positive rewriteRelativeI...) into release-5.7 (#...</li> <li><a href="https://github.com/microsoft/TypeScript/commit/44bd3f21fe50b3ea28c881b38814701e105cabdc"><code>44bd3f2</code></a> Bump version to 5.7.1-rc and LKG</li> <li><a href="https://github.com/microsoft/TypeScript/commit/5925c81eea81c2d8a484db993efc4d471ddf8bd2"><code>5925c81</code></a> Update LKG</li> <li><a href="https://github.com/microsoft/TypeScript/commit/84d58cf52522d0ceed1f2a00f5c8443ff9d86698"><code>84d58cf</code></a> Merge remote-tracking branch 'origin/main' into release-5.7</li> <li><a href="https://github.com/microsoft/TypeScript/commit/0ec4d30a6e2ebbc87292c9829378d4e98de8ef43"><code>0ec4d30</code></a> Fixing exception on unsaved file (<a href="https://redirect.github.com/microsoft/TypeScript/issues/60362">#60362</a>)</li> <li><a href="https://github.com/microsoft/TypeScript/commit/11b2930fa2c9f73b0ffb725a9715b8d3c4121bbc"><code>11b2930</code></a> Add compatible overloads that accept ArrayBuffer to BigInt64Array/BigUint64Ar...</li> <li>Additional commits viewable in <a href="https://github.com/microsoft/TypeScript/compare/v5.6.3...v5.7.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…artant#48) Bumps [@stylistic/eslint-plugin](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin) from 2.10.1 to 2.11.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/eslint-stylistic/eslint-stylistic/releases"><code>@stylistic/eslint-plugin</code>'s releases</a>.</em></p> <blockquote> <h2>v2.11.0</h2> <h2><a href="https://github.com/eslint-stylistic/eslint-stylistic/compare/v2.10.1...v2.11.0">2.11.0</a> (2024-11-19)</h2> <h3>Features</h3> <ul> <li><strong>comma-dangle:</strong> add support for Import Attributes (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/586">#586</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/4c177c35057652e3872f65756fa62dc05b34cf93">4c177c3</a>)</li> <li><strong>comma-style:</strong> add support for more syntax (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/597">#597</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/922151c98b2dc75ad4a135f082050b9dd1b26d11">922151c</a>)</li> <li><strong>function-call-argument-newline:</strong> add support for Import Attributes (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/603">#603</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/8ee0c24da827c36da3df2e9724744b88fc3aa988">8ee0c24</a>)</li> <li><strong>function-call-spacing:</strong> add <code>optionalChain</code> to control the space around the <code>optional chain</code> (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/605">#605</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/f73279887c755db71e47cb3248fea746fb34e783">f732798</a>)</li> <li><strong>function-paren-newline:</strong> add support for Import Attributes (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/585">#585</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/4ede153af46af01ed3250e16365975e034631455">4ede153</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li>fix the <code>update</code> script in <code>Windows</code> (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/604">#604</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/dede11938e3e15a9e36efefeb548eaa1f3cb1484">dede119</a>)</li> </ul> <h3>Build Related</h3> <ul> <li><strong>deps:</strong> bump codecov/codecov-action from 4 to 5 (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/612">#612</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/047a3840e43bea3731c5bef629e18a06b10c55a8">047a384</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/eslint-stylistic/eslint-stylistic/blob/main/CHANGELOG.md"><code>@stylistic/eslint-plugin</code>'s changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/eslint-stylistic/eslint-stylistic/compare/v2.10.1...v2.11.0">2.11.0</a> (2024-11-19)</h2> <h3>Features</h3> <ul> <li><strong>comma-dangle:</strong> add support for Import Attributes (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/586">#586</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/4c177c35057652e3872f65756fa62dc05b34cf93">4c177c3</a>)</li> <li><strong>comma-style:</strong> add support for more syntax (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/597">#597</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/922151c98b2dc75ad4a135f082050b9dd1b26d11">922151c</a>)</li> <li><strong>function-call-argument-newline:</strong> add support for Import Attributes (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/603">#603</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/8ee0c24da827c36da3df2e9724744b88fc3aa988">8ee0c24</a>)</li> <li><strong>function-call-spacing:</strong> add <code>optionalChain</code> to control the space around the <code>optional chain</code> (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/605">#605</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/f73279887c755db71e47cb3248fea746fb34e783">f732798</a>)</li> <li><strong>function-paren-newline:</strong> add support for Import Attributes (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/585">#585</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/4ede153af46af01ed3250e16365975e034631455">4ede153</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li>fix the <code>update</code> script in <code>Windows</code> (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/604">#604</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/dede11938e3e15a9e36efefeb548eaa1f3cb1484">dede119</a>)</li> </ul> <h3>Build Related</h3> <ul> <li><strong>deps:</strong> bump codecov/codecov-action from 4 to 5 (<a href="https://redirect.github.com/eslint-stylistic/eslint-stylistic/issues/612">#612</a>) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/047a3840e43bea3731c5bef629e18a06b10c55a8">047a384</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/11e83d8adbd9e92c3ed443236f525a342056d36b"><code>11e83d8</code></a> chore: release v2.11.0 (main) (<a href="https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin/issues/613">#613</a>)</li> <li><a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/8ee0c24da827c36da3df2e9724744b88fc3aa988"><code>8ee0c24</code></a> feat(function-call-argument-newline): add support for Import Attributes (<a href="https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin/issues/603">#603</a>)</li> <li><a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/4c177c35057652e3872f65756fa62dc05b34cf93"><code>4c177c3</code></a> feat(comma-dangle): add support for Import Attributes (<a href="https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin/issues/586">#586</a>)</li> <li><a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/4ede153af46af01ed3250e16365975e034631455"><code>4ede153</code></a> feat(function-paren-newline): add support for Import Attributes (<a href="https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin/issues/585">#585</a>)</li> <li><a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/922151c98b2dc75ad4a135f082050b9dd1b26d11"><code>922151c</code></a> feat(comma-style): add support for more syntax (<a href="https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin/issues/597">#597</a>)</li> <li><a href="https://github.com/eslint-stylistic/eslint-stylistic/commit/f73279887c755db71e47cb3248fea746fb34e783"><code>f732798</code></a> feat(function-call-spacing): add <code>optionalChain</code> to control the space around ...</li> <li>See full diff in <a href="https://github.com/eslint-stylistic/eslint-stylistic/commits/v2.11.0/packages/eslint-plugin">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…t#49) Bumps [eslint-plugin-n](https://github.com/eslint-community/eslint-plugin-n) from 17.13.2 to 17.14.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/eslint-community/eslint-plugin-n/releases">eslint-plugin-n's releases</a>.</em></p> <blockquote> <h2>v17.14.0</h2> <h2><a href="https://github.com/eslint-community/eslint-plugin-n/compare/v17.13.2...v17.14.0">17.14.0</a> (2024-11-21)</h2> <h3>🌟 Features</h3> <ul> <li><strong>no-sync:</strong> Add ignores option (<a href="https://redirect.github.com/eslint-community/eslint-plugin-n/issues/386">#386</a>) (<a href="https://github.com/eslint-community/eslint-plugin-n/commit/c8fbf000e337d3b099e89465adda3be8e0541554">c8fbf00</a>)</li> <li><strong>no-unsupported:</strong> support Node 23.2.0 & 23.3.0 (<a href="https://redirect.github.com/eslint-community/eslint-plugin-n/issues/390">#390</a>) (<a href="https://github.com/eslint-community/eslint-plugin-n/commit/a52c96813496c346cd9cacc23df8ade2567012af">a52c968</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/eslint-community/eslint-plugin-n/blob/master/CHANGELOG.md">eslint-plugin-n's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/eslint-community/eslint-plugin-n/compare/v17.13.2...v17.14.0">17.14.0</a> (2024-11-21)</h2> <h3>🌟 Features</h3> <ul> <li><strong>no-sync:</strong> Add ignores option (<a href="https://redirect.github.com/eslint-community/eslint-plugin-n/issues/386">#386</a>) (<a href="https://github.com/eslint-community/eslint-plugin-n/commit/c8fbf000e337d3b099e89465adda3be8e0541554">c8fbf00</a>)</li> <li><strong>no-unsupported:</strong> support Node 23.2.0 & 23.3.0 (<a href="https://redirect.github.com/eslint-community/eslint-plugin-n/issues/390">#390</a>) (<a href="https://github.com/eslint-community/eslint-plugin-n/commit/a52c96813496c346cd9cacc23df8ade2567012af">a52c968</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/eslint-community/eslint-plugin-n/commit/ccf5f9e482c32f2fd2d5f78649d7f837a5db8870"><code>ccf5f9e</code></a> chore(master): release 17.14.0 (<a href="https://redirect.github.com/eslint-community/eslint-plugin-n/issues/387">#387</a>)</li> <li><a href="https://github.com/eslint-community/eslint-plugin-n/commit/a52c96813496c346cd9cacc23df8ade2567012af"><code>a52c968</code></a> feat(no-unsupported): support Node 23.2.0 & 23.3.0 (<a href="https://redirect.github.com/eslint-community/eslint-plugin-n/issues/390">#390</a>)</li> <li><a href="https://github.com/eslint-community/eslint-plugin-n/commit/c8fbf000e337d3b099e89465adda3be8e0541554"><code>c8fbf00</code></a> feat(no-sync): Add ignores option (<a href="https://redirect.github.com/eslint-community/eslint-plugin-n/issues/386">#386</a>)</li> <li>See full diff in <a href="https://github.com/eslint-community/eslint-plugin-n/compare/v17.13.2...v17.14.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
@Danevandy99 You could open a PR for this rule under fork |
Uncovered lint error from bumping typescript-eslint from 8.15.0 to 8.16.0. Also fixes incorrect typescript-eslint warning during `yarn lint-js` about TypeScript 5.7 being unsupported.
|
@JasonWeinzierl I'll open a PR over in the fork. |
…ant#55) BREAKING CHANGE: `no-ignored-observable` is removed; use `no-floating-observables` instead. - Enhance floating observable logic to handle more than just call expressions. - Now that `no-ignored-observable` is included in the `strict` config, enhancing it will be more widely useful. - Add `ignoreVoid` option. When `false`, this rule will reach past the `void` operator and check its argument. Defaults to `true` (i.e. `void` can be used to ignore floating observables). - Rename rule from `no-ignored-observable` to `no-floating-observables`. - As mentioned in cartant#43 , we should take advantage of this project being a fork to clarify rule names, and typescript-eslint has an existing convention for promises that would be nice to imitate for observables: one rule covers floating, the other covers misused. - An alternative is keeping the old rule as-is and deprecating it. However, this forked project is not v1 yet, so we should take advantage of prerelease to make breaking changes early instead of putting them off for a later, more painful date.
BREAKING CHANGE: RxJS ^7.2.0 is required. BREAKING CHANGE: `recommended` configuration had 4 rules added to it. See full changelog for details. Resolves cartant#35 . - `no-topromise`: `toPromise()` was deprecated by RxJS, so this will be very useful for helping developers migrate to one of the two manual editor suggestions (`lastValueFrom` or `firstValueFrom`). - `prefer-observer`: RxJS deprecated non-observer object subscribes, so this will help migrate. - `prefer-root-operators`: RxJS moved operators to root in 7.2.0 and deprecated the old site, so this will help migrate. - This change requires bumping the RxJS peer dependency to 7.2.0 because 7.0.0 doesn't export the operators from root. - `throw-error`: This rule will rarely be triggered because it was recently changed to only apply to the static creation function `throwError()`. But in those rare cases, it should always be enforced, similar to `no-implicit-any-catch`.
New rule based on `@typescript-eslint/no-misused-promises`. Ensures you don't return an Observable where void is expected, or try to spread an Observable. This rule is added to the `strict` configuration. Resolves cartant#43 . Note: `checksVoidReturn` is noticeably slow, specifically stemming from the `arguments`, `properties`, and `variables` sub-options. It's still faster than `@typescript-eslint/no-deprecated` and some `import-x` rules, but it's in the top 10 with `TIMING=1` enabled. But since the implementation is similar to `@typescript-eslint/no-misused-promises` which has similar performance, we'll allow it.
Bumps the vitest group with 3 updates: [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8), [@vitest/eslint-plugin](https://github.com/vitest-dev/eslint-plugin-vitest) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `@vitest/coverage-v8` from 2.1.5 to 2.1.6 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vitest-dev/vitest/releases"><code>@vitest/coverage-v8</code>'s releases</a>.</em></p> <blockquote> <h2>v2.1.6</h2> <h2>🚀 Features</h2> <ul> <li>Support Vite 6</li> </ul> <h5> <a href="https://github.com/vitest-dev/vitest/compare/v2.1.5...v2.1.6">View changes on GitHub</a></h5> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitest-dev/vitest/commit/b936702debce5a9deca637b25950afa485ad3639"><code>b936702</code></a> bump: 2.1.6</li> <li>See full diff in <a href="https://github.com/vitest-dev/vitest/commits/v2.1.6/packages/coverage-v8">compare view</a></li> </ul> </details> <br /> Updates `@vitest/eslint-plugin` from 1.1.10 to 1.1.13 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vitest-dev/eslint-plugin-vitest/releases"><code>@vitest/eslint-plugin</code>'s releases</a>.</em></p> <blockquote> <h2>v1.1.13</h2> <h2>What's Changed</h2> <ul> <li>Enhance "all" configuration and update documentation by <a href="https://github.com/y-hsgw"><code>@y-hsgw</code></a> in <a href="https://redirect.github.com/vitest-dev/eslint-plugin-vitest/pull/578">vitest-dev/eslint-plugin-vitest#578</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/vitest-dev/eslint-plugin-vitest/compare/v1.1.12...v1.1.13">https://github.com/vitest-dev/eslint-plugin-vitest/compare/v1.1.12...v1.1.13</a></p> <h2>v1.1.12</h2> <h3>Bug Fixes</h3> <ul> <li>dependancy import (<a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/a63b6c9">a63b6c9</a>)</li> </ul> <h2>What's Changed</h2> <ul> <li>[valid-expect] Support typecheck by <a href="https://github.com/y-hsgw"><code>@y-hsgw</code></a> in <a href="https://redirect.github.com/vitest-dev/eslint-plugin-vitest/pull/576">vitest-dev/eslint-plugin-vitest#576</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/vitest-dev/eslint-plugin-vitest/compare/v1.1.11...v1.1.12">https://github.com/vitest-dev/eslint-plugin-vitest/compare/v1.1.11...v1.1.12</a></p> <h2>v1.1.11</h2> <h2>What's Changed</h2> <ul> <li>docs: correct "ESLint" and "Vitest" capitalization in README.md by <a href="https://github.com/JoshuaKGoldberg"><code>@JoshuaKGoldberg</code></a> in <a href="https://redirect.github.com/vitest-dev/eslint-plugin-vitest/pull/575">vitest-dev/eslint-plugin-vitest#575</a></li> <li>[valid-expect] include fixer for adding missing await by <a href="https://github.com/y-hsgw"><code>@y-hsgw</code></a> in <a href="https://redirect.github.com/vitest-dev/eslint-plugin-vitest/pull/574">vitest-dev/eslint-plugin-vitest#574</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/y-hsgw"><code>@y-hsgw</code></a> made their first contribution in <a href="https://redirect.github.com/vitest-dev/eslint-plugin-vitest/pull/574">vitest-dev/eslint-plugin-vitest#574</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/vitest-dev/eslint-plugin-vitest/compare/v1.1.10...v1.1.11">https://github.com/vitest-dev/eslint-plugin-vitest/compare/v1.1.10...v1.1.11</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/feb04a5963da5513c8c7a2b62c369a803d894c1f"><code>feb04a5</code></a> chore: release v1.1.13</li> <li><a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/e4133d5942bc0112f96fb61330914a965148c5d7"><code>e4133d5</code></a> chore: update deps</li> <li><a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/ec2366eb49e4c74ed7cdf834eaf4dc7ae4ae7a47"><code>ec2366e</code></a> Enhance "all" configuration and update documentation (<a href="https://redirect.github.com/vitest-dev/eslint-plugin-vitest/issues/578">#578</a>)</li> <li><a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/541f8b710cebeec2c8c943d416078246d2bde1e7"><code>541f8b7</code></a> chore: release v1.1.12</li> <li><a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/a63b6c9496d7fdde21e13635649ef9d1d696f211"><code>a63b6c9</code></a> fix: dependancy import</li> <li><a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/177aad00450e13264ea91f1a8794571b52ff647c"><code>177aad0</code></a> [valid-expect] Support typecheck (<a href="https://redirect.github.com/vitest-dev/eslint-plugin-vitest/issues/576">#576</a>)</li> <li><a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/1f4ff4758083aaec4b35a95e2dca137072cc1d04"><code>1f4ff47</code></a> chore: release v1.1.11</li> <li><a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/1da7ed4d89a2eade8fee9e831003f5832bc29d4c"><code>1da7ed4</code></a> [valid-expect] include fixer for adding missing await (<a href="https://redirect.github.com/vitest-dev/eslint-plugin-vitest/issues/574">#574</a>)</li> <li><a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/6388046472dcafe23db7029e10b8a8a56af34fec"><code>6388046</code></a> docs: correct "ESLint" and "Vitest" capitalization in README.md (<a href="https://redirect.github.com/vitest-dev/eslint-plugin-vitest/issues/575">#575</a>)</li> <li>See full diff in <a href="https://github.com/vitest-dev/eslint-plugin-vitest/compare/v1.1.10...v1.1.13">compare view</a></li> </ul> </details> <br /> Updates `vitest` from 2.1.5 to 2.1.6 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vitest-dev/vitest/releases">vitest's releases</a>.</em></p> <blockquote> <h2>v2.1.6</h2> <h2>🚀 Features</h2> <ul> <li>Support Vite 6</li> </ul> <h5> <a href="https://github.com/vitest-dev/vitest/compare/v2.1.5...v2.1.6">View changes on GitHub</a></h5> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitest-dev/vitest/commit/b936702debce5a9deca637b25950afa485ad3639"><code>b936702</code></a> bump: 2.1.6</li> <li>See full diff in <a href="https://github.com/vitest-dev/vitest/commits/v2.1.6/packages/vitest">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jason Weinzierl <[email protected]>
We're keeping node types in line with the lowest supported Node.js version, so dependabot should ignore all but patch updates. Also bump PR limit to 10.
Bumps the vitest group with 3 updates: [@vitest/coverage-v8](https://github.com/vitest-dev/vitest/tree/HEAD/packages/coverage-v8), [@vitest/eslint-plugin](https://github.com/vitest-dev/eslint-plugin-vitest) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `@vitest/coverage-v8` from 2.1.6 to 2.1.8 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vitest-dev/vitest/releases"><code>@vitest/coverage-v8</code>'s releases</a>.</em></p> <blockquote> <h2>v2.1.8</h2> <h3> 🐞 Bug Fixes</h3> <ul> <li>Support Node 21 - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> <a href="https://github.com/vitest-dev/vitest/commit/92f7a2ad"><!-- raw HTML omitted -->(92f7a)<!-- raw HTML omitted --></a></li> </ul> <h5> <a href="https://github.com/vitest-dev/vitest/compare/v2.1.7...v2.1.8">View changes on GitHub</a></h5> <h2>v2.1.7</h2> <h3> 🐞 Bug Fixes</h3> <ul> <li>Revert support for Vite 6 - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> <a href="https://github.com/vitest-dev/vitest/commit/fbe5c39d"><!-- raw HTML omitted -->(fbe5c)<!-- raw HTML omitted --></a> <ul> <li>This introduced some breaking changes (<a href="https://redirect.github.com/vitest-dev/vitest/issues/6992">vitest-dev/vitest#6992</a>). We will enable support for it later. In the meantime, you can still use <code>pnpm.overrides</code> or yarn resolutions to override the <code>vite</code> version in the <code>vitest</code> package - the APIs are compatible.</li> </ul> </li> </ul> <h5> <a href="https://github.com/vitest-dev/vitest/compare/v2.1.6...v2.1.7">View changes on GitHub</a></h5> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitest-dev/vitest/commit/d69cc75698dd6dbeaed5c237ebb46ccd41bfb438"><code>d69cc75</code></a> bump: 2.1.8</li> <li><a href="https://github.com/vitest-dev/vitest/commit/81ed45b3a46759ac5b8aaa3a5fad80767316c4ae"><code>81ed45b</code></a> chore: release v2.1.7</li> <li>See full diff in <a href="https://github.com/vitest-dev/vitest/commits/v2.1.8/packages/coverage-v8">compare view</a></li> </ul> </details> <br /> Updates `@vitest/eslint-plugin` from 1.1.13 to 1.1.14 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vitest-dev/eslint-plugin-vitest/releases"><code>@vitest/eslint-plugin</code>'s releases</a>.</em></p> <blockquote> <h2>v1.1.14</h2> <h2>What's Changed</h2> <ul> <li>docs: Add Documentation for valid-expect-in-promise Rule by <a href="https://github.com/y-hsgw"><code>@y-hsgw</code></a> in <a href="https://redirect.github.com/vitest-dev/eslint-plugin-vitest/pull/581">vitest-dev/eslint-plugin-vitest#581</a></li> <li>[valid-describe-callback] Fix to support options as second parameter for valid-describe-callback by <a href="https://github.com/y-hsgw"><code>@y-hsgw</code></a> in <a href="https://redirect.github.com/vitest-dev/eslint-plugin-vitest/pull/582">vitest-dev/eslint-plugin-vitest#582</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/vitest-dev/eslint-plugin-vitest/compare/v1.1.13...v1.1.14">https://github.com/vitest-dev/eslint-plugin-vitest/compare/v1.1.13...v1.1.14</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/66fbbce7b2b240d680a562584c6af6ea5250a0da"><code>66fbbce</code></a> chore: release v1.1.14</li> <li><a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/a1ef5162f50c934e28c9136a817ec2ce578677c7"><code>a1ef516</code></a> [valid-describe-callback] Fix to support options as second parameter for vali...</li> <li><a href="https://github.com/vitest-dev/eslint-plugin-vitest/commit/6ad414f46514e8ddfa738e90c9fc4736fea2cd29"><code>6ad414f</code></a> docs: Add Documentation for valid-expect-in-promise Rule (<a href="https://redirect.github.com/vitest-dev/eslint-plugin-vitest/issues/581">#581</a>)</li> <li>See full diff in <a href="https://github.com/vitest-dev/eslint-plugin-vitest/compare/v1.1.13...v1.1.14">compare view</a></li> </ul> </details> <br /> Updates `vitest` from 2.1.6 to 2.1.8 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vitest-dev/vitest/releases">vitest's releases</a>.</em></p> <blockquote> <h2>v2.1.8</h2> <h3> 🐞 Bug Fixes</h3> <ul> <li>Support Node 21 - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> <a href="https://github.com/vitest-dev/vitest/commit/92f7a2ad"><!-- raw HTML omitted -->(92f7a)<!-- raw HTML omitted --></a></li> </ul> <h5> <a href="https://github.com/vitest-dev/vitest/compare/v2.1.7...v2.1.8">View changes on GitHub</a></h5> <h2>v2.1.7</h2> <h3> 🐞 Bug Fixes</h3> <ul> <li>Revert support for Vite 6 - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> <a href="https://github.com/vitest-dev/vitest/commit/fbe5c39d"><!-- raw HTML omitted -->(fbe5c)<!-- raw HTML omitted --></a> <ul> <li>This introduced some breaking changes (<a href="https://redirect.github.com/vitest-dev/vitest/issues/6992">vitest-dev/vitest#6992</a>). We will enable support for it later. In the meantime, you can still use <code>pnpm.overrides</code> or yarn resolutions to override the <code>vite</code> version in the <code>vitest</code> package - the APIs are compatible.</li> </ul> </li> </ul> <h5> <a href="https://github.com/vitest-dev/vitest/compare/v2.1.6...v2.1.7">View changes on GitHub</a></h5> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitest-dev/vitest/commit/d69cc75698dd6dbeaed5c237ebb46ccd41bfb438"><code>d69cc75</code></a> bump: 2.1.8</li> <li><a href="https://github.com/vitest-dev/vitest/commit/92f7a2ad18453343bfef1333af4b4c8191f72ec4"><code>92f7a2a</code></a> fix: support Node 21</li> <li><a href="https://github.com/vitest-dev/vitest/commit/81ed45b3a46759ac5b8aaa3a5fad80767316c4ae"><code>81ed45b</code></a> chore: release v2.1.7</li> <li><a href="https://github.com/vitest-dev/vitest/commit/fbe5c39d8891abcd91dc6b03720ee2b6c7678197"><code>fbe5c39</code></a> fix: revert support for Vite 6</li> <li>See full diff in <a href="https://github.com/vitest-dev/vitest/commits/v2.1.8/packages/vitest">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- Add `name` to recommended and strict configurations. Enforce via unit test. - Also add more keywords to the npm package as recommended by eslint.org. [Configuration name is optional but recommended](https://eslint.org/docs/latest/use/configure/configuration-files#configuration-naming-conventions). The old eslintrc format does not support name, but since we don't support eslintrc, we're ok to add `name`.
…ithin `pipe` operators
Danevandy99
force-pushed
the
no-subscribe-in-pipe
branch
from
49f2749 to
7448e49
Compare
Co-authored-by: Jason Weinzierl <[email protected]> Signed-off-by: Dane Vanderbilt <[email protected]>
JasonWeinzierl
added a commit
to JasonWeinzierl/eslint-plugin-rxjs-x
that referenced
this pull request
Dec 4, 2024
…hin pipe operators (#59) BREAKING CHANGE: new rule added to `recommended` config. New rule to forbid calling `subscribe` within `pipe`. This was previously caught by `no-nested-subscribe` until it was changed due to cartant#67. This rule was proposed to the original repo and was re-proposed here by request: cartant#131 (comment) Signed-off-by: Dane Vanderbilt <[email protected]> Co-authored-by: Jason Weinzierl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.