fix(no-ignored-replay-buffer): check if bufferSize is set in config option for shareReplay #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption for shareReplay Fixes cartant#100
JasonWeinzierl
added a commit
to JasonWeinzierl/eslint-plugin-rxjs-x
that referenced
this pull request
Nov 8, 2024
Fixes cartant#100 There's also a proposed fix PR in the upstream repo cartant#114 but I avoided looking at that solution to avoid any license issue, so this solution might be different. - Fix: if the `shareReplay` operator was passed an object config, then require `bufferSize` to be in that object. - Fix: the rule wasn't handling if `shareReplay` is imported under a namespace. - (Might need to review the entire project. Since rxjs now recommends importing from "rxjs" instead of "rxjs/operators", there's a risk that many rules also fail to account for that new paradigm. Note that this rule is the only rule that tests namespace imports for all cases, so we at least should expand that coverage/type of test.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100