Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat✨: add button sorting a-z -> z-a #111

Closed
wants to merge 37 commits into from
Closed

feat✨: add button sorting a-z -> z-a #111

wants to merge 37 commits into from

Conversation

ali-benny
Copy link
Member

Si ordinano separatamente directory e file A-Z o Z-A in base al bottone

This close #46

Si ordinano separatamente directory e file A-Z o Z-A in base al bottone
@ali-benny ali-benny requested review from VaiTon and a team as code owners October 8, 2023 10:23
@vercel
Copy link

vercel bot commented Oct 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dynamik ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2023 9:05am

@ali-benny ali-benny changed the title feat✨: add button for sorting a-z -> z-a feat✨: add button sorting a-z -> z-a Oct 8, 2023
@VaiTon
Copy link
Member

VaiTon commented Oct 8, 2023

L'icona in realtà non mi ispira particolarmente xD. Inoltre direi che è ora di iniziare ad usare https://iconify.design/. Nel pomeriggio faccio una PR

@lucat1
Copy link
Collaborator

lucat1 commented Oct 8, 2023

Non l’ho specificato nella issue originale ma la mia idea originale era di mettere questa cosa come preferenza permanente nelle settings. Si potrebbe fare che c’è sia una opzione nelle setting e poi la si può invertire con un toggle temporaneo presente nelle pagine di listing.

@ali-benny
Copy link
Member Author

Non l’ho specificato nella issue originale ma la mia idea originale era di mettere questa cosa come preferenza permanente nelle settings. Si potrebbe fare che c’è sia una opzione nelle setting e poi la si può invertire con un toggle temporaneo presente nelle pagine di listing.

ah, ma non è più pratico così?

@ali-benny
Copy link
Member Author

L'icona in realtà non mi ispira particolarmente xD.

Oh, okay.. perchè?

Inoltre direi che è ora di iniziare ad usare https://iconify.design/. Nel pomeriggio faccio una PR

Sono d'accordissimo

@foxyseta
Copy link
Member

foxyseta commented Oct 8, 2023

@ali-benny ricordati di usare pnpm format! Sennò il codice non è ben formattato e giustamente i controlli falliscono.

Momentaneamente uso iconify con svg, facciamo una pr apposta per convertire tutte le icone[emoji] nel sito ad iconify
ali-benny and others added 2 commits October 9, 2023 09:34
* fix(style): join border-color match
Ora il bordo dell' `<li>` matcha con anche il bordo join, prima con il tema chiaro si vedeva proprio la riga bianca invece di quella scura.

* pnpm format
@ali-benny
Copy link
Member Author

ho cambiato l'icona su #114, se il resto va bene si può fare merge

@VaiTon VaiTon mentioned this pull request Oct 9, 2023
dependabot bot and others added 4 commits October 13, 2023 13:04
Bumps [@types/marked](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/marked) from 5.0.1 to 6.0.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/marked)

---
updated-dependencies:
- dependency-name: "@types/marked"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the minor-patches group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [@sveltejs/kit](https://github.com/sveltejs/kit/tree/HEAD/packages/kit) | `1.25.1` | `1.25.2` |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.7.4` | `6.7.5` |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.7.4` | `6.7.5` |
| [marked](https://github.com/markedjs/marked) | `9.1.0` | `9.1.1` |
| [shiki](https://github.com/octref/shiki) | `0.14.4` | `0.14.5` |


Updates `@sveltejs/kit` from 1.25.1 to 1.25.2
- [Release notes](https://github.com/sveltejs/kit/releases)
- [Changelog](https://github.com/sveltejs/kit/blob/master/packages/kit/CHANGELOG.md)
- [Commits](https://github.com/sveltejs/kit/commits/@sveltejs/[email protected]/packages/kit)

Updates `@typescript-eslint/eslint-plugin` from 6.7.4 to 6.7.5
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.5/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 6.7.4 to 6.7.5
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.7.5/packages/parser)

Updates `marked` from 9.1.0 to 9.1.1
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v9.1.0...v9.1.1)

Updates `shiki` from 0.14.4 to 0.14.5
- [Release notes](https://github.com/octref/shiki/releases)
- [Changelog](https://github.com/shikijs/shiki/blob/main/CHANGELOG.md)
- [Commits](shikijs/shiki@v0.14.4...v0.14.5)

---
updated-dependencies:
- dependency-name: "@sveltejs/kit"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-patches
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-patches
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-patches
- dependency-name: marked
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-patches
- dependency-name: shiki
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-patches
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the minor-patches group with 3 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin), [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) and [marked](https://github.com/markedjs/marked).


Updates `@typescript-eslint/eslint-plugin` from 6.7.5 to 6.8.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.8.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 6.7.5 to 6.8.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.8.0/packages/parser)

Updates `marked` from 9.1.1 to 9.1.2
- [Release notes](https://github.com/markedjs/marked/releases)
- [Changelog](https://github.com/markedjs/marked/blob/master/.releaserc.json)
- [Commits](markedjs/marked@v9.1.1...v9.1.2)

---
updated-dependencies:
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: minor-patches
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: minor-patches
- dependency-name: marked
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-patches
...

Signed-off-by: dependabot[bot] <[email protected]>
@ali-benny
Copy link
Member Author

@VaiTon bump

ali-benny and others added 2 commits October 20, 2023 16:49
* chore(icon): add iconify as tailwindcss integration
* style(icon): home into breadcrumbs
* style(icon): github redirect link
* style(icon): fuzzy search btn
* style(icon): back btn into build
* style(icon): back btn into settings
* style(icon): download btn
* style(icon): back into course

---------

Co-authored-by: VaiTon <[email protected]>
* fix: rect open graph image into preview
* chore: removed space
* fix: og and titles in courses and dashes

---------

Co-authored-by: VaiTon <[email protected]>
@VaiTon
Copy link
Member

VaiTon commented Oct 24, 2023

@ali-benny mi sa che qualche merge ha fatto un po' di casino... La diff ha elementi che non c'entrano nulla con la PR

dependabot bot and others added 4 commits October 24, 2023 23:33
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps the minor-patches group with 11 updates:

| Package | From | To |
| --- | --- | --- |
| [@iconify-json/material-symbols](https://github.com/iconify/icon-sets) | `1.1.59` | `1.1.60` |
| [@sveltejs/kit](https://github.com/sveltejs/kit/tree/HEAD/packages/kit) | `1.25.2` | `1.27.0` |
| [@types/dompurify](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/dompurify) | `3.0.3` | `3.0.4` |
| [@types/jsdom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jsdom) | `21.1.3` | `21.1.4` |
| [@types/katex](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/katex) | `0.16.3` | `0.16.5` |
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `6.8.0` | `6.9.0` |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `6.8.0` | `6.9.0` |
| [daisyui](https://github.com/saadeghi/daisyui) | `3.9.2` | `3.9.3` |
| [eslint](https://github.com/eslint/eslint) | `8.51.0` | `8.52.0` |
| [svelte](https://github.com/sveltejs/svelte/tree/HEAD/packages/svelte) | `4.2.1` | `4.2.2` |
| [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) | `4.4.11` | `4.5.0` |


Updates `@iconify-json/material-symbols` from 1.1.59 to 1.1.60
- [Commits](iconify/icon-sets@1.1.59...1.1.60)

Updates `@sveltejs/kit` from 1.25.2 to 1.27.0
- [Release notes](https://github.com/sveltejs/kit/releases)
- [Changelog](https://github.com/sveltejs/kit/blob/master/packages/kit/CHANGELOG.md)
- [Commits](https://github.com/sveltejs/kit/commits/@sveltejs/[email protected]/packages/kit)

Updates `@types/dompurify` from 3.0.3 to 3.0.4
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/dompurify)

Updates `@types/jsdom` from 21.1.3 to 21.1.4
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jsdom)

Updates `@types/katex` from 0.16.3 to 0.16.5
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/katex)

Updates `@typescript-eslint/eslint-plugin` from 6.8.0 to 6.9.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.9.0/packages/eslint-plugin)

Updates `@typescript-eslint/parser` from 6.8.0 to 6.9.0
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.9.0/packages/parser)

Updates `daisyui` from 3.9.2 to 3.9.3
- [Changelog](https://github.com/saadeghi/daisyui/blob/master/CHANGELOG.md)
- [Commits](saadeghi/daisyui@v3.9.2...v3.9.3)

Updates `eslint` from 8.51.0 to 8.52.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.51.0...v8.52.0)

Updates `svelte` from 4.2.1 to 4.2.2
- [Release notes](https://github.com/sveltejs/svelte/releases)
- [Changelog](https://github.com/sveltejs/svelte/blob/master/packages/svelte/CHANGELOG.md)
- [Commits](https://github.com/sveltejs/svelte/commits/[email protected]/packages/svelte)

Updates `vite` from 4.4.11 to 4.5.0
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.0/packages/vite)

---
updated-dependencies:
- dependency-name: "@iconify-json/material-symbols"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-patches
- dependency-name: "@sveltejs/kit"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: minor-patches
- dependency-name: "@types/dompurify"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-patches
- dependency-name: "@types/jsdom"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-patches
- dependency-name: "@types/katex"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-patches
- dependency-name: "@typescript-eslint/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: minor-patches
- dependency-name: "@typescript-eslint/parser"
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: minor-patches
- dependency-name: daisyui
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-patches
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: minor-patches
- dependency-name: svelte
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: minor-patches
- dependency-name: vite
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: minor-patches
...

Signed-off-by: dependabot[bot] <[email protected]>
* replaces eslint svelte
* fix lint errors
* Update config

* chore: update config

* feat: add AI

* chore: update config: ai id
@ali-benny
Copy link
Member Author

@ali-benny mi sa che qualche merge ha fatto un po' di casino... La diff ha elementi che non c'entrano nulla con la PR

a quali file ti riferisci in particolare? non ho trovato cose "extra"

@VaiTon
Copy link
Member

VaiTon commented Oct 25, 2023

.gitignore, package.json, ...

@ali-benny
Copy link
Member Author

.gitignore, package.json, ...

Nel main ci sono diversi merge di pr che aggiornavano cose nel package, facendo rebase si sono aggiunte. Mi stai facendo venire il dubbio che vuole rimettere le versioni vecchie?

Nel .gitignore l'unica aggiunta è .vercel non capisco il problema.

@VaiTon
Copy link
Member

VaiTon commented Oct 26, 2023

Mi stai facendo venire il dubbio che vuole rimettere le versioni vecchie?

Eh si

@ali-benny
Copy link
Member Author

ali-benny commented Oct 28, 2023

@VaiTon vedo di fixare, scusami

Si ordinano separatamente directory e file A-Z o Z-A in base al bottone
Momentaneamente uso iconify con svg, facciamo una pr apposta per convertire tutte le icone[emoji] nel sito ad iconify
Si ordinano separatamente directory e file A-Z o Z-A in base al bottone
@ali-benny
Copy link
Member Author

@VaiTon bump 🥺

@VaiTon
Copy link
Member

VaiTon commented Nov 6, 2023

@ali-benny ci sono ancora un sacco di file modificati che non c'entrano nulla con la PR. Riusciamo a ricreare la PR e fare cherry pick sui commit che ci interessano?

@ali-benny
Copy link
Member Author

@ali-benny ci sono ancora un sacco di file modificati che non c'entrano nulla con la PR. Riusciamo a ricreare la PR e fare cherry pick sui commit che ci interessano?

AAaaa uf domani provo

@VaiTon VaiTon closed this in #148 Nov 9, 2023
@ali-benny ali-benny deleted the sorting-list branch November 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opzione per ordinare le prove dalle piu recenti alle più datate
5 participants