Skip to content

Config option to support pre-styled share button #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahemoff wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Config option to support pre-styled share button #224

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
04f9335
Config option to support pre-styled share button
mahemoff Sep 21, 2015
ccd1fe9
Merge branch 'carrot'
mahemoff Feb 17, 2016
f6e7f6d
code formatting - space around ==
mahemoff Feb 20, 2016
f21d309
Merge branch 'carrot'
mahemoff Feb 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/ShareButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,14 @@ class ShareButton extends ShareUtils {
for (let network of networks) {
networkList += `<li class='${network}' data-network='${network}'><a></a></li>`;
}
instance.innerHTML = `${this.config.ui.buttonText}<div class='${this.config.ui.namespace}social load ${this.config.ui.flyout}'><ul>` + networkList + `</ul></div>`;

// Configure buttonText as false to leave button text alone
var buttonText = this.config.ui.buttonText;
if (buttonText==false) {
Copy link
Contributor

@hhsnopek hhsnopek Feb 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add spacing around the == comparison for me? - this'll be good to go after that 😄

buttonText = instance.innerHTML;
}

instance.innerHTML = `${buttonText}<div class='${this.config.ui.namespace}social load ${this.config.ui.flyout}'><ul>` + networkList + `</ul></div>`;
}

/**
Expand Down