-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in cutting call out #1643
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries/instructor-training/compare/md-outputs..md-outputs-PR-1643 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-06-04 15:56:46 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree this is an improvement and addresses the most important parts of the issue. My only question is whether this should be an instructor note (e.g. trainer note) instead of a callout? That is, should everyone who goes to the lesson see it or only if they're using instructor mode?
That is a good point, actually with instructor view, maybe we do audience specific versions approximately like:
|
Separate instuctor note on cutting from callout (visible to learners) with encouragement to use as a resource.
@brownsarahm what do you think of the changes I proposed in response to your suggestion? |
I like it, thanks! @ndporter |
Auto-generated via {sandpaper} Source : 7044711 Branch : main Author : Nathaniel D Porter <[email protected]> Time : 2024-06-13 19:06:20 +0000 Message : Merge pull request #1643 from carpentries/cutting_typo Fix typo in cutting call out and split instructor/learner notes
Auto-generated via {sandpaper} Source : 06ed373 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 19:07:14 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 7044711 Branch : main Author : Nathaniel D Porter <[email protected]> Time : 2024-06-13 19:06:20 +0000 Message : Merge pull request #1643 from carpentries/cutting_typo Fix typo in cutting call out and split instructor/learner notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I will merge.
Auto-generated via {sandpaper} Source : 06ed373 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-06-13 19:07:14 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 7044711 Branch : main Author : Nathaniel D Porter <[email protected]> Time : 2024-06-13 19:06:20 +0000 Message : Merge pull request #1643 from carpentries/cutting_typo Fix typo in cutting call out and split instructor/learner notes
attempts to fix #1642
I did something slightly different than the suggestion, but i agree there was a typo in the box.
I think leaving it at the top actually makes sense for two reasons:
If others 1) agree with that rationale 2) think it is worth making more findable, we could put a (shortend; edited for clarity) version of that justification in the box too.