Skip to content

correct callout type#1605

Merged
ndporter merged 1 commit intomainfrom
karenword-patch-2
Oct 26, 2023
Merged

correct callout type#1605
ndporter merged 1 commit intomainfrom
karenword-patch-2

Conversation

@karenword
Copy link
Copy Markdown
Contributor

This quote is not a testimonial.

Fixing this one only, but note that there may be other errors of this kind, because the prior template did not label the callouts and were sometimes selected based on color rather than strict categorical matching!

This quote is not a testimonial. 

Fixing this one only, but note that there may be other errors of this kind, because the prior template did not label the callouts and were sometimes selected based on color rather than strict categorical matching!
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 20, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/instructor-training/compare/md-outputs..md-outputs-PR-1605

The following changes were observed in the rendered markdown documents:

 02-practice-learning.md | 2 +-
 md5sum.txt              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-10-20 21:52:18 +0000

github-actions Bot pushed a commit that referenced this pull request Oct 20, 2023
Copy link
Copy Markdown
Contributor

@dpshelio dpshelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's the only one, the other two seems real.

instructor-training/episodes on karenword-patch-2 
❯ rg -A 5 testimonial
02-practice-learning.md
434::::::::::::::::::::::::::::::::::::::  testimonial
435-
436-If someone feels it is too slow, they will be a bit bored. If they feel it is too fast, they will never come back to programming.
437-— Kunal Marwaha, SWC Instructor
438-
439-

08-motivation.md
184::::::::::::::::::::::::::::::::::::::  testimonial
185-
186-## Typos
187-
188-The typos are the pedagogy.
189-— Emily Jane McTavish

@ndporter
Copy link
Copy Markdown
Contributor

I'm going to merge this as-is, but I made an issue (#1608 ) to check the type/structure of various special sections and ensure it's consistent. I think this is probably low-priority, but it's there as a reminder.

@ndporter ndporter merged commit c7cbe3d into main Oct 26, 2023
@ndporter ndporter deleted the karenword-patch-2 branch October 26, 2023 15:06
github-actions Bot pushed a commit that referenced this pull request Oct 26, 2023
Auto-generated via {sandpaper}
Source  : c7cbe3d
Branch  : main
Author  : Nathaniel D Porter <ndporter@vt.edu>
Time    : 2023-10-26 15:06:43 +0000
Message : Merge pull request #1605 from carpentries/karenword-patch-2

correct callout type
github-actions Bot pushed a commit that referenced this pull request Oct 26, 2023
Auto-generated via {sandpaper}
Source  : adbfa92
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-10-26 15:08:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c7cbe3d
Branch  : main
Author  : Nathaniel D Porter <ndporter@vt.edu>
Time    : 2023-10-26 15:06:43 +0000
Message : Merge pull request #1605 from carpentries/karenword-patch-2

correct callout type
github-actions Bot pushed a commit that referenced this pull request Oct 31, 2023
Auto-generated via {sandpaper}
Source  : adbfa92
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-10-26 15:08:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c7cbe3d
Branch  : main
Author  : Nathaniel D Porter <ndporter@vt.edu>
Time    : 2023-10-26 15:06:43 +0000
Message : Merge pull request #1605 from carpentries/karenword-patch-2

correct callout type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants