Skip to content

updated params for endpoint #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pavliuc75 wants to merge 5 commits into
base: main
Choose a base branch
from
Open

updated params for endpoint #34

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b17ce2b
updated params for endpoint
pavliuc75 Jun 24, 2025
fde887a
updated params for endpoint (test)
pavliuc75 Jun 24, 2025
9b499c0
updated ver
pavliuc75 Jun 25, 2025
abb5ac8
updated CHANGELOG.md
pavliuc75 Jun 25, 2025
cf165fc
Added `is_descending` parameters to `getParticipantAccounts` endpoint
pavliuc75 Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/endpoints/study/recruitment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,17 +81,28 @@ class Recruitment extends Endpoint {
offset,
search,
response_as_dto,
is_descending,
order_by,
}: {
studyId: string;
limit?: number | null;
offset?: number | null;
search?: string | null;
response_as_dto?: boolean | null;
is_descending?: boolean | null;
order_by?: "Username" | "Email" | null;
}) {
const response = await this.actions.get<
ParticipantAccount[] | PaginatedParticipantAccounts
>(`${this.wsEndpoint}/${studyId}/participants/accounts`, {
params: { limit, offset, search, response_as_dto },
params: {
limit,
offset,
search,
response_as_dto,
is_descending,
order_by,
},
Copy link

Copilot AI Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider filtering out null or undefined values before sending the params object so that unwanted query strings (e.g., is_descending=null) are not included in the request URL.

Suggested change
params: {
limit,
offset,
search,
response_as_dto,
is_descending,
order_by,
},
params: Object.fromEntries(
Object.entries({
limit,
offset,
search,
response_as_dto,
is_descending,
order_by,
}).filter(([_, value]) => value != null),
),

Copilot uses AI. Check for mistakes.
});

return response.data;
Expand Down
Loading