Skip to content

Conversation

@jakdan99
Copy link
Contributor

@jakdan99 jakdan99 commented May 1, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the serialization logic for data streams by replacing the use of MutableDataStreamBatch with CarpDataStreamBatch and revising how batches are serialized and appended. Key changes include:

  • Replacing MutableDataStreamBatch with CarpDataStreamBatch in tests and endpoint implementations.
  • Revising the serialization logic to iterate over batch.sequences.
  • Adding a new test case for appending an unknown data type.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
src/test/endpoints/dataStreams.test.ts Updated tests to use CarpDataStreamBatch and introduced tests for unknown data streams.
src/endpoints/dataStreams.ts Changed batch type to CarpDataStreamBatch and updated request serialization logic.
CHANGELOG.md Updated changelog to document the serialization fix.
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (1)

src/endpoints/dataStreams.ts:59

  • CarpDataStreamBatch is used as a type but no corresponding import statement is visible; please add the appropriate import to ensure that the type is recognized.
batch: CarpDataStreamBatch;

@github-actions
Copy link

github-actions bot commented May 1, 2025

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 84.31% (🎯 80%) 1446 / 1715
🟢 Statements 84.31% (🎯 80%) 1446 / 1715
🟢 Functions 85.34% (🎯 80%) 99 / 116
🟢 Branches 93.7% (🎯 80%) 134 / 143
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/endpoints/dataStreams.ts 100% 92.85% 100% 100%
Generated in workflow #32 for commit 07a6e4f by the Vitest Coverage Report Action

@jakdan99 jakdan99 merged commit a25dbe0 into develop May 1, 2025
5 of 6 checks passed
@jakdan99 jakdan99 deleted the feature/custom-request-serializer-for-data-streams branch May 9, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants