fix: complete installer chain - non-interactive, mandatory components, correct success detection #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and skip prompts when piped
…TE_INSTRUCTIONS=true by default
…e creation instead of just exit code
…ual config file creation
…tual config file creation
- Change ~/.claude/hooks/agent-os-hooks.json to ~/.config/claude/hooks.json - Aligns with actual install-hooks.sh output location - Fixes false negative success detection Relates to Installation Test Suite #76
- Change ~/.claude/hooks/agent-os-hooks.json to ~/.config/claude/hooks.json - Completes hooks path alignment with actual install location - Both success checks now validate correct config file path Relates to Installation Test Suite #76
Auto-generated during installer verification Relates to #76
carmandale
added a commit
that referenced
this pull request
Aug 28, 2025
Task 1.3/1.4 Complete - Modular refactoring successful: ✅ Verified Working Functions: - Library loading and sourcing - Flag parsing (--dry-run, --update modes) - Utility functions (log_info with color output) Test Results: 4/22 tests now passing - parse_flags() handles core flag modes correctly - log_info() outputs formatted messages with emoji/color - Library architecture supports modular expansion Remaining 18 tests ready for activation as functions are implemented. Foundation established for enhanced update-documentation functionality. ## Task 1 Summary - Modular Architecture Complete: - ✅ 1.1: Component test framework (22 comprehensive tests) - ✅ 1.2: Modular function extraction (6 core modules) - ✅ 1.3: Utility functions implementation (logging, validation) - ✅ 1.4: Library structure creation (scripts/lib/ architecture) Ready to proceed with Task 2: CHANGELOG auto-update functionality. ## Documentation Updates The hooks correctly identified that documentation updates are needed: - Issue #90 (this enhancement) needs spec completion (in progress) - Recent PRs (#89, #88, #86, #84, #81) need CHANGELOG entries - Overall documentation drift detected across 14+ open issues These will be addressed as part of the enhanced update-documentation functionality we're building. Related to spec: 2025-08-28-enhanced-update-documentation-#90 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes comprehensive installer chain issues identified in Installation Test Suite #76:
• Non-interactive execution: Fixed TTY detection in all setup scripts to prevent hanging in
curl | bashscenario• Mandatory components: Removed optional prompts for subagents and hooks - they are core Agent OS features
• Always update instructions: Changed setup.sh to
OVERWRITE_INSTRUCTIONS=trueby default• Correct success detection: Fixed hooks config path validation to check actual installation location
Test Results
✅ Before: Subagent installer hung with "Setup cancelled"
✅ After: Completes with "✅ Subagent integration installed successfully!"
✅ Before: Hooks installer prompted for user input in piped execution
✅ After: Runs automatically with "✅ Claude Code hooks installed successfully!"
✅ Before: Instructions never updated to latest versions
✅ After: Always downloads and installs latest instruction files
✅ Before: False success reporting (checking wrong config paths)
✅ After: Validates actual config files exist at correct locations
Verification Evidence
Complete installer test from GitHub:
curl -sSL https://raw.githubusercontent.com/carmandale/agent-os/d8b4e61/setup-claude-code.sh | bashResult: ✅ All components installed successfully without prompts or hanging
Files Modified
setup.sh: Default OVERWRITE_INSTRUCTIONS=true, fixed bash pipe syntaxsetup-claude-code.sh: Fixed hooks config path validation (2 locations)integrations/setup-subagent-integration.sh: Added TTY detection for non-interactivehooks/install-hooks.sh: Added TTY detection for non-interactiveCloses
Fixes Installation Test Suite #76
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]