Skip to content

renaming to factories package #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlosjimz87 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

renaming to factories package #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65a346b
renaming to factories package
carlosjimz87 Jul 9, 2021
17a323d
temp remove DetailsViewModelTest until solve context issue
carlosjimz87 Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...funwithflags/factory/ViewModelsFactory.kt → ...nwithflags/factories/ViewModelsFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.carlosjimz87.funwithflags.factory
package com.carlosjimz87.funwithflags.factories

import androidx.lifecycle.ViewModel
import androidx.lifecycle.ViewModelProvider
Expand Down
3 changes: 1 addition & 2 deletions app/src/main/java/com/carlosjimz87/funwithflags/fragments/details/DetailsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,8 @@ import androidx.navigation.fragment.navArgs
import com.carlosjimz87.funwithflags.App
import com.carlosjimz87.funwithflags.R
import com.carlosjimz87.funwithflags.databinding.DetailsFragmentBinding
import com.carlosjimz87.funwithflags.factory.ViewModelsFactory
import com.carlosjimz87.funwithflags.factories.ViewModelsFactory
import com.carlosjimz87.funwithflags.fragments.BaseFragment
import com.carlosjimz87.funwithflags.repositories.CountriesRepositoryImpl
import com.google.android.gms.maps.CameraUpdateFactory
import com.google.android.gms.maps.GoogleMap
import com.google.android.gms.maps.OnMapReadyCallback
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/carlosjimz87/funwithflags/fragments/list/ListFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import com.carlosjimz87.funwithflags.App
import com.carlosjimz87.funwithflags.R
import com.carlosjimz87.funwithflags.adapters.CountryListAdapter
import com.carlosjimz87.funwithflags.databinding.ListFragmentBinding
import com.carlosjimz87.funwithflags.factory.ViewModelsFactory
import com.carlosjimz87.funwithflags.factories.ViewModelsFactory
import com.carlosjimz87.funwithflags.fragments.BaseFragment
import com.carlosjimz87.funwithflags.utils.addDividerShape
import timber.log.Timber
Expand Down
56 changes: 0 additions & 56 deletions app/src/test/java/com/carlosjimz87/funwithflags/fragments/details/DetailsViewModelTest.kt
View file
Open in desktop

This file was deleted.