Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go version for Docker file carlosedp/golang to 1.23.6 #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielboven
Copy link

@danielboven danielboven commented Feb 5, 2025

Background

The Docker image carlosedp/golang is quite extensively used by other Docker images (in the build process). For instance, the shenxn/protonmail-bridge relies on the Go image to build the mail bridge.
For them to be updated, the carlosedp/golang should be bumped to a newer version of Go. I have made small changes to the Dockerfile.golang to allow updating to Go version 1.23.6. I have tested this with success on two different architectures.

Changelog

  • Updated VER variable to 1.23.6.
  • Changed Golang download URL to current base URL.
  • Removed alternative RISCV64 download location (i.e. Go archive in this GitHub repository), as Go releases now ship a RISCV64 version from the downloads by default.
  • Changed ENV declarations format in Dockerfile.golang as these were using an outdated format. This prevents the Docker warning LegacyKeyValueFormat.

Small request

If @carlosedp approves this pull request, would you mind updating the Docker image on the container registry (using the command outlined in the top of the Dockerfile.golang)? Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant