Merge pull request #27 from careyjames/tushar-dkimrecords

correct code
careyjames · Oct 19, 2023 · 9b27c93 · 9b27c93
2 parents 8fb83b9 + 2bbc238
commit 9b27c93
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/dns_information/dmarc.go b/dns_information/dmarc.go
@@ -42,7 +42,7 @@ func GetDMARCPrompt(input string) {
 			formattedDMARC := formatLongText(dmarc, 80, " ")
 			fmt.Printf(color.Blue(" DMARC Record: ") + color.Green(formattedDMARC) + constants.Newline)
 		} else {
-			fmt.Printf(color.Blue(" DMARC Record: ") + color.Green(dmarc[8:]) + constants.Newline)
+			fmt.Printf(color.Blue(" DMARC Record: ") + color.Red(dmarc[8:]) + constants.Newline)
 		}
 	} else {
 		fmt.Printf(color.Blue(" DMARC Record: ") + color.Red("None") + constants.Newline)

diff --git a/dns_information/dmki_info.go b/dns_information/dmki_info.go
@@ -36,13 +36,17 @@ func getDKIM(domain string, selector string) (string, error) {
 func GetDKIMPrompt(input string) {
 	flag := false
 	dkimPrompt := ""
-	for _, selector := range DKIMSelectors {
+	for index, selector := range DKIMSelectors {
 		dkim, _ := getDKIM(input, selector)
 		if dkim != "" {
 			flag = true
 			if isValidDKIM(dkim) {
 				formattedDMARC := formatLongText(dkim, 80, " ")
-				dkimPrompt += color.Green(selector+".") + color.Green(formattedDMARC) + constants.Newline
+				if index > 0 {
+					dkimPrompt += " " + color.Green(selector+".") + color.Green(formattedDMARC) + constants.Newline
+				} else {
+					dkimPrompt += color.Green(selector+".") + color.Green(formattedDMARC) + constants.Newline
+				}
 			} else {
 				dkimPrompt += color.Green(selector+".") + color.Red(dkim[7:]) + constants.Newline
 			}
@@ -53,9 +57,9 @@ func GetDKIMPrompt(input string) {
 		}
 	}
 	if flag {
-		fmt.Printf(color.Blue(" DKIM Record: ") + dkimPrompt)
+		fmt.Printf(color.Blue(" DKIM Records: ") + dkimPrompt)
 	} else {
-		fmt.Printf(color.Blue(" DKIM Record: ") + dkimPrompt)
+		fmt.Printf(color.Blue(" DKIM Records: ") + dkimPrompt)
 	}
 }