Skip to content

Mgu insights supply #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2025
Merged

Mgu insights supply #335

merged 3 commits into from
Oct 6, 2025

Conversation

gufmar
Copy link
Contributor

@gufmar gufmar commented Oct 3, 2025

This PR picks up the initial work done for the supply page, and improve it on many places.

  • add epoch navigation
  • add API error handling
  • improve performance (parallel API calls)
  • move generic insight code into libs
  • text, header and SEO optimization
  • mobile view improvements
  • add and improve explanatory sentences (facts section)

UI Notes:

  • for insight pages we remove the sitehero banner and focus
  • the epoch navigation does not update router and keeps the y-position
  • the epoch navbar is floating and dynamic on mobile view
  • we show donut and table data together, and avoid any hidden content, that indexers and parser should see and consider.

Special epochs to test and check the conditional content

  • ?epoch=375 thousands of withdrawal requests
  • ?epoch=409 single withdrawal request
  • ?epoch=495 single large withdrawal request
  • ?epoch=322 many smaller withdrawals, less than addition

known Todo's

  • Conway withdrawals
  • Donations

gufmar added 2 commits October 2, 2025 09:31
@gufmar
improve supply data and explanations
8805615 
- remove sitehero for insights
- add epoch navigation
- page header SEO optimizations
- enhance fetch and computed data
- improve descriptive sentences
- add anchor links
@gufmar
improvements
c228e12 
- api error handling
- api parallel requests
- improved nav bar
- moved general insight code into api, error, numbers and epoch libs
@gufmar gufmar requested review from 0xBora and katomm October 3, 2025 17:56
katomm
katomm approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@katomm katomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, that said everything in src/libs should be in src/components/somewhere

@katomm katomm merged commit 8462b0a into staging Oct 6, 2025
1 check passed
@katomm katomm mentioned this pull request Oct 10, 2025
Merged
katomm added a commit that referenced this pull request Oct 10, 2025
@katomm
Merge pull request #337 from cardano-foundation/staging
5ef760e 
Merge PR #322, #321, #327, #325, #328, #326, #333, #324, #335, #336 into main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katomm katomm katomm approved these changes

@0xBora 0xBora Awaiting requested review from 0xBora

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gufmar @katomm