Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test that shows names are not poisoned when lookup fails #4774

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Add a test that shows names are not poisoned when lookup fails #4774

merged 1 commit into from
Jan 8, 2025

Conversation

bricknerb
Copy link
Contributor

@bricknerb bricknerb commented Jan 8, 2025 •
edited by jonmeow
Loading

Part of #4622

@github-actions github-actions bot requested a review from chandlerc January 8, 2025 10:05
@bricknerb bricknerb mentioned this pull request Jan 8, 2025
Merged
@bricknerb bricknerb requested review from zygoloid and jonmeow January 8, 2025 10:13
jonmeow
jonmeow approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since this at least reflects current behavior, separate from #4766

@jonmeow jonmeow added this pull request to the merge queue Jan 8, 2025
@jonmeow
Copy link
Contributor

jonmeow commented Jan 8, 2025

@bricknerb FYI I modified the PR description to give some context for why #4662 is mentioned ("Part of"). I think it will benefit from context in commit history.

Merged via the queue into carbon-language:trunk with commit 7d92aa7 Jan 8, 2025
8 checks passed
@bricknerb bricknerb deleted the poison branch January 9, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmeow jonmeow jonmeow approved these changes

@chandlerc chandlerc Awaiting requested review from chandlerc

@zygoloid zygoloid Awaiting requested review from zygoloid

Assignees
No one assigned
Labels
toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bricknerb @jonmeow