Name Poisoning #4622

bricknerb · 2024-12-04T07:18:53Z

…4635) This is a preparation change for introducing name poisoning (#4622), which would have broken this test.

carbon-language#4622 When using an unqualified name disallow using that name in all scopes that would make it ambiguous in retrospect. Doesn't include support for poisoning when importing (see new test for that with TODO). Implemented by introduce InstId::PoisonedName and entries with it to NameScope.

This is a preparation change for adding name poisoning support (#4622), which is expected to require more elaborate logic around NameScope since a name can be not defined yet, defined, or poisoned. The API separates looking up a name from getting the full entry since we have cases where the entries are invalidated between the time we're looking for the name and when we access (and sometimes modify) the entry. This change has the following benefits: * `names` and `name_map` are internal to `NameScope` and are guaranteed to match. * `extended_scopes` and `import_ir_scopes` can not be manipulated (only new scopes can be added). * `inst_id`, `name_id` and `parent_scope_id` are constants. * `has_error` can only be mutated from false to true. --------- Co-authored-by: jonmeow <[email protected]>

carbon-language#4622 When using an unqualified name disallow using that name in all scopes that would make it ambiguous in retrospect. Doesn't include support for poisoning when importing (see new test for that with TODO). Implemented by introduce `InstId::PoisonedName` and entries with it to `NameScope`.

#4622 When using an unqualified name, disallow declaring that name in all scopes that would make it ambiguous in retrospect. Doesn't include support for poisoning in `impl library` (see new test for that with TODO). Implemented by introduce `InstId::PoisonedName` and entries with it to `NameScope`. --------- Co-authored-by: Dana Jansens <[email protected]> Co-authored-by: Richard Smith <[email protected]> Co-authored-by: Geoff Romer <[email protected]> Co-authored-by: Jon Ross-Perkins <[email protected]> Co-authored-by: josh11b <[email protected]> Co-authored-by: josh11b <[email protected]> Co-authored-by: Chandler Carruth <[email protected]> Co-authored-by: Carbon Infra Bot <[email protected]>

This prevents crashing when the wrongly used impl uses a poisoned name. carbon-language#4622

This prevents crashing when the wrongly used `impl` uses a poisoned name. #4622

…soned` bit instead of `InstId::PoisonedName` value. This would allow to more easily change the API to support accessing the poisoning delcaration so we can have better name poisoning diagnosis. carbon-language#4622

Change the implementation to use an explicit `is_poisoned` bit instead of `InstId::PoisonedName` value. Zero behavior change. This would allow to more easily change the API to support accessing the poisoning declaration so we can have better name poisoning diagnosis. #4622

carbon-language#4622

#4622

Insert the poison at the same time we do the name lookup to avoid doing two hash table lookups into each scope. This adds a bit of complication because import logic now needs to cope with importing a name that is already poisoned, but the complexity seems worthwhile to reduce the number of name lookups performed. This incidentally fixes a bug where we wouldn't poison any name scopes if we found the name in an enclosing lexical scope, leading to one extra diagnostic in existing tests. Part of #4622

This was referenced Dec 4, 2024

[NFC] Convert NameScope from struct to class #4623

Merged

In indirect_import_member test, make the alias avoid name poisoning #4635

Merged

github-merge-queue bot pushed a commit that referenced this issue Dec 5, 2024

In indirect_import_member test, make the alias avoid name poisoning (#…

1409666

…4635) This is a preparation change for introducing name poisoning (#4622), which would have broken this test.

bricknerb mentioned this issue Dec 6, 2024

Basic name poisoning support bricknerb/carbon-lang#1

Closed

bricknerb mentioned this issue Dec 9, 2024

Basic name poisoning support #4654

Merged

bricknerb self-assigned this Dec 17, 2024

bricknerb added a commit to bricknerb/carbon-lang that referenced this issue Jan 3, 2025

Do not try to recover from using impl outside class error

8c572f4

This prevents crashing when the wrongly used impl uses a poisoned name. carbon-language#4622

bricknerb mentioned this issue Jan 3, 2025

Do not try to recover from using impl outside class error #4755

Merged

github-merge-queue bot pushed a commit that referenced this issue Jan 3, 2025

Do not try to recover from using impl outside class error (#4755)

72e594d

This prevents crashing when the wrongly used `impl` uses a poisoned name. #4622

bricknerb mentioned this issue Jan 7, 2025

Change name poisoning implementation to allow better diagnostics #4764

Merged

bricknerb mentioned this issue Jan 8, 2025

Rearrange name poisoning logic to do a little less work. #4766

Merged

bricknerb added a commit to bricknerb/carbon-lang that referenced this issue Jan 8, 2025

Add a test that shows names are not poisoned when lookup fails

c893671

carbon-language#4622

bricknerb mentioned this issue Jan 8, 2025

Add a test that shows names are not poisoned when lookup fails #4774

Merged

bricknerb added a commit to bricknerb/carbon-lang that referenced this issue Jan 8, 2025

Add a test that shows names are not poisoned when lookup fails

0ee5ed5

carbon-language#4622

github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2025

Add a test that shows names are not poisoned when lookup fails (#4774)

7d92aa7

#4622

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Name Poisoning #4622

Name Poisoning #4622

bricknerb commented Dec 4, 2024 •

edited

Loading

Name Poisoning #4622

Name Poisoning #4622

Comments

bricknerb commented Dec 4, 2024 • edited Loading

bricknerb commented Dec 4, 2024 •

edited

Loading