Skip to content

Conversation

@Yashrajsingh2001
Copy link
Contributor

SCSS Code Snippets Review

Critical Errors

1. Line 220: Missing quotes in motion mixin

"body": "@include motion(entrance, 'expressive')"

Issue: entrance should be quoted as 'entrance'
Should be: "body": "@include motion('entrance', 'expressive')"

2. Line 328: Incorrect capitalization

"body": "@include type-style('productive-Heading-02')"

Issue: Heading has capital H, should be lowercase
Should be: "body": "@include type-style('productive-heading-02')"

Summary

Total Issues Found: 2

  1. Line 220 - Missing quotes around entrance parameter in motion mixin
  2. Line 328 - Incorrect capitalization: productive-Heading-02 should be productive-heading-02

Both issues would cause runtime errors when the snippets are used, as Carbon Design System expects exact token names with consistent lowercase formatting.

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@Yashrajsingh2001
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

Copy link
Member

@lee-chase lee-chase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These corrections is good, thanks for the fix.

Note: #247 proposal could move maintenance out of this repo, but merging this is correct pending a wider review of config.

@lee-chase lee-chase merged commit 60e74ca into carbon-design-system:main Nov 18, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants