fix(leadspace): wrong gradient display when in RLT mode #12180
+77
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-amorim
requested review from
marcelojcs and
Valentin-Sorin-Nicolae
and removed request for
a team
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
marcelojcs
approved these changes
Jan 8, 2025
marcelojcs
added
the
Ready to merge
|
The gradient is changing using 'rotate(90)' but the image stays the same. I think the image needs a flip also, right? |
…-dotcom into fix/leadspace-gradient-issue-rtl
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…background when in RTL mode
…-dotcom into fix/leadspace-gradient-issue-rtl
…morim/carbon-for-ibm-dotcom into fix/leadspace-gradient-issue-rtl
✅ Deploy Preview for incomparable-wisp-8d6771 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Closes # ADCMS-7399
Description
In the Leadspace component, when in RTL mode, the text would be displayed from the right to left but the gradient in the image would still be from the left to the right, causing the text to be unreadable in images with low contrast.
I also took the opportunity to fix the leadspace with video background - when in RTL, the video was not spanning the full width of its container.