fix(multi-select): address a11y issues #2231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metonym
force-pushed
the
multiselect-a11y-fix
branch
from
e276a2b to
e3c5757
Compare
|
Fixed in v0.89.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2172
Closes #2188, closes #2187
This PR fixes critical accessibility violations in the MultiSelect component identified by the IBM Equal Access Accessibility Checker. The component was using improper role nesting with
role="button"wrapping interactive elements, causing keyboard accessibility issues and screen reader confusion.The fix restructures both filterable and non-filterable variants to use
role="combobox"directly on the interactive element without nested button roles, following the same pattern used in the ComboBox component. For the filterable variant, the input element now serves as the combobox with properaria-labelledby,aria-controls, andaria-ownsattributes. For the non-filterable variant, the ListBoxField usesrole="combobox"instead ofrole="button", witharia-activedescendantfor proper keyboard navigation tracking.The PR updates all existing tests to reflect the role changes and adds 7 new accessibility-focused regression tests.