final#1
Open
cappers86 wants to merge 3 commits into
Open
Conversation
ropeks
reviewed
Oct 3, 2019
Collaborator
ropeks
left a comment
ropeks
left a comment
There was a problem hiding this comment.
This looks good, still along way to go, but you're making good progress 🎉 🎉 . Just make sure you're comfortable with flex before Sprint challenge tomorrow @cappers86
| } | ||
| ol, ul { | ||
| list-style: none; | ||
| list-style: ; |
| text-decoration: none; | ||
| } | ||
| .navigation { | ||
| display: inline-block; |
Comment on lines
+19
to
+103
| <body> | ||
|
|
||
| <header id="nav-bar"> | ||
| <nav class="navigation"> | ||
| <a href="services.html">Services</a> | ||
| <a href="">Product</a> | ||
| <a href="">Vision</a> | ||
| <a href="">Features</a> | ||
| <a href="">About</a> | ||
| <a href="">Contact</a> | ||
| </nav> | ||
|
|
||
| <img class="logo" src="img/logo.png" alt="Great Idea! Company logo."> | ||
|
|
||
| </header> | ||
|
|
||
| <section id="innovation-demand"> | ||
| <div id="innovatetext"> | ||
| <h1 id="title">Innovation <br> | ||
| On<br> | ||
| Demand | ||
| </h1> | ||
| <button id="start-button"> Get Started</button> | ||
| </div> | ||
| <div id="innovate-imgage"> | ||
| <img src="img/header-img.png" alt="Image of a code snippet."> | ||
| </div> | ||
| </section> | ||
|
|
||
| <hr> | ||
| <section class="upper-section"> | ||
| <div id="features"> | ||
| <h3 class="subsection1"> Features</h3> | ||
| <p>Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. | ||
| Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis.</p> | ||
| </div> | ||
| <div id="about"> | ||
| <h3 class="subsection1"> About</h3> | ||
| <p>Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. | ||
| Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis.</p> | ||
| </div> | ||
| </section> | ||
|
|
||
| <img class="wide-img" src="img/mid-page-accent.jpg" alt="Image of code snippets across the screen"> | ||
|
|
||
| <section class="lower-section"> | ||
| <div id="services"> | ||
| <h3 class="sub-section2">Services</h3> | ||
| <p>Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. | ||
| Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis. | ||
| </p> | ||
| </div> | ||
|
|
||
| <div id="product"> | ||
| <h3 class="sub-section2">Product</h3> | ||
| <p>Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. | ||
| Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis. | ||
| </p> | ||
| </div> | ||
|
|
||
| <div id="vison"> | ||
| <h3 class="sub-section2">Vision</h3> | ||
| <p>Aliquam elementum magna eros, ac posuere elvit tempus et. Suspendisse vel tempus odio, in interdutm nisi. | ||
| Suspendisse eu ornare nisl. Nullam convallis augue justo, at imperdiet metus scelerisque quis. | ||
|
|
||
| </p> | ||
| </div> | ||
| </section> | ||
|
|
||
| <hr> | ||
| <section class="contact-us"> | ||
| <h3 class="contact">Contact</h3> | ||
| <p>Address: 123 Way 456 Street</p> | ||
| <p>Somewhere, USA</p> | ||
| <br> | ||
| <p>Phone: 1 (888) 888-8888</p> | ||
| <br> | ||
| <p>Email: sales@greatidea.io</p> | ||
| </section> | ||
|
|
||
| <div id="legal"> | ||
| Copyright Great Idea! 2018 | ||
| </div> | ||
|
|
||
| </body> |
Comment on lines
+92
to
+93
| <p>Somewhere, USA</p> | ||
| <br> |
Collaborator
There was a problem hiding this comment.
you can use just one of those (either <br> or wrap it in <p>) because <p> tag actually separates what's wrapped in it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colin Toft