Skip to content

Conversation

@ebolyen
Copy link
Member

@ebolyen ebolyen commented Oct 2, 2025

By default unannotated tags are not considered by versioningit.

By default unannotated tags are not considered by versioningit.
@lizgehret
Copy link
Collaborator

this was discussed offline and can be closed bc versions are fixed once we do an official distro release that includes said plugin(s).

@lizgehret lizgehret closed this Oct 9, 2025
@ebolyen
Copy link
Member Author

ebolyen commented Oct 9, 2025

What about 3rd party devs? I didn't really think this change was for our lab, and it wouldn't change q2-boots or q2-kmerizer anyhow.

@lizgehret
Copy link
Collaborator

Maybe I'm missing something but my understanding was that this was opened bc of boots/kmerizer versions - and you and @gregcaporaso had decided we could close this since their versions will be fixed in the upcoming release:

Screenshot 2025-10-09 at 10 27 58 AM

@ebolyen
Copy link
Member Author

ebolyen commented Oct 9, 2025

Sorry for the confusion, I meant that there were 2 issues:
image

q2-boots and q2-kmerizer don't really need any action, hence leaving them as is (and closing the Draft issue on the project board Greg opened). But any 3rd party devs are going to run into the same issue as those plugins, except they won't be in a distro release, so their versions will always be weird if they use a Github release instead of a specifically formed tag. And since Library tries to highlight github releases, it would be weird if they have those, and a version of 0.0.1+300 etc

@lizgehret
Copy link
Collaborator

lizgehret commented Oct 9, 2025

Ah, I see. I'll need to take a closer look at this then - my understanding is that Greg ran into an issue with the listed version when running qiime info. The versions listed on library (from GH releases) do work as expected though, and the conda/python versions are correct.

@lizgehret lizgehret reopened this Oct 9, 2025
@lizgehret lizgehret self-assigned this Oct 9, 2025
@lizgehret lizgehret moved this to Needs Review in 2026.1 ❄️ Oct 9, 2025
@ebolyen
Copy link
Member Author

ebolyen commented Oct 9, 2025

ok! I think if we make a fresh templated plugin and then do a GH release (and then make a library style env file) we should see the issue. And if we don't then I don't actually know what's going on anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants