fix: format size to close percentage with fixed 2 decimal places (Fixes #11)#239
Open
zeroknowledge0x wants to merge 1 commit into
Open
fix: format size to close percentage with fixed 2 decimal places (Fixes #11)#239zeroknowledge0x wants to merge 1 commit into
zeroknowledge0x wants to merge 1 commit into
Conversation
- Use toFixed(2) instead of formatForDisplay for percentage display - Ensures consistent formatting regardless of percentage value - Fixes issue where percentage could show too many decimal places Fixes capofficial#11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the size to close percentage formatting issue (#11) where the percentage could display with too many decimal places.
Changes
Cause and Fix
Cause: The function uses dynamic decimal places based on the number magnitude. For percentages, this could result in inconsistent formatting (e.g., vs ).
Fix: Use directly on the percentage value for consistent 2 decimal place formatting.
Acceptance Criteria
Closes #11