Add a Steal() method to Client and ClientSnapshot #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and use it to catch a bug; the test is failing, need to track it down.
|
Alright, fixed the failing tests. |
zenhack
changed the title
Otherwise the target message steals the caps, resulting in errors later when we try to read them.
|
Just noticed that the .AddRef() in localpromise.go actually introduces a leak... I'm somewhat inclined to punt for now though, because the way the code works one of those Fulfills wants to be borrowed, and #480 gets rid of one of them anyway, which will make this much easier to fix. |
lthibault
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and use it to catch a bug; the test is failing, need to track it down.