-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setUserId accept null too #49 #50
base: master
Are you sure you want to change the base?
Conversation
Any update on this PR? I am also waiting on this fix |
I have some time set aside later this week for this. |
Hi, I also need to unset the userId via setUserId. @brownoxford do you think you need help to merge this PR? |
@brownoxford @edouardruiz any updates? |
Also interested by this. Any news @brownoxford? |
@markxoe it seems your PR is not fixing the issue unfortunately. For example on iOS: firebase-analytics/ios/Plugin/Plugin.swift Lines 25 to 29 in 962a666
Since it expects a "string" it will raise an error in all cases. Did you test your implementation? (maybe I'm doing something wrong) |
I've solved #49 so that
null
will be accepted bysetUserId
and in the web-version it gets converted to an empty string