Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin to support multiple plugins in the same project #41

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Update plugin to support multiple plugins in the same project #41

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2016f48
fixed compilation error TS2794: Expected 1 arguments, but got 0
Dec 7, 2020
80e7d2b
Added initial support for multi Firebase plugins in the same project
Dec 7, 2020
8256fae
fixed Firebase script is loaded several times
Dec 7, 2020
be8a150
[refactor] gather plugins' common code together
Dec 7, 2020
2830da9
[refactor] unify plugin's common code with capacitor-community/fireba…
Dec 7, 2020
ea17070
fixed firebase may not be ready on firebaseObjectReadyPromise
Dec 8, 2020
4978d65
[privacy] removed unrequired Firebase/Core pod
Dec 14, 2020
eb0fe10
fixed [bug] project supports capacitor 2
Jun 6, 2021
8fa1827
update depentant packages
Jun 6, 2021
bb1d0ff
fixed [bug] method setScreenName is no longer supported.
Jun 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,15 +289,15 @@ export class FirebaseAnalyticsWeb extends WebPlugin
document.getElementById(scripts[0]) &&
document.getElementById(scripts[1])
) {
return resolve();
return resolve( null );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of passing a value where none is expected, can you modify the promise to declare a type, e.g.:

return new Promise<void>(async (resolve, _reject) => {

}

await this.loadScript(firebaseAppScript.key, firebaseAppScript.src);
await this.loadScript(
firebaseAnalyticsScript.key,
firebaseAnalyticsScript.src
);
resolve();
resolve( null );
});
}

Expand Down