Added section about async profiler with cf java #1771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Spelling Mistakes
- java/operating-applications/optimizing.md:56:8 Unknown word "Asprof"
- java/operating-applications/optimizing.md:57:34 Unknown word "asprof"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
| Choosing an output filename with .html ending indicates to use the output type `flamegraph`, see [FlameGraph visualization](https://github.com/async-profiler/async-profiler/blob/master/docs/GettingStarted.md#flamegraph-visualization) | ||
| ::: | ||
|
|
||
| `.html` files can be opened in a browser, `.jfr` files can be viewed with a viewer such as [OpenJDK Mission Control](https://openjdk.org/projects/jmc/). |
There was a problem hiding this comment.
can jfr files also be opened in intellij or vscode?
There was a problem hiding this comment.
In IntelliJ only with the Ultimate Edition. For VSCode I'm not aware of any extension that could open jfr files.
There was a problem hiding this comment.
Johannes hat ein PLugin für intellij gebaut - nur das ist eher noch instabil. Du kannst ihn ja fragen, ob wir es schon verlinken sollen
There was a problem hiding this comment.
Linting Errors
- java/operating-applications/optimizing.md:73 Fenced code blocks should have a language specified
- java/operating-applications/optimizing.md:78 Fenced code blocks should have a language specified
- java/operating-applications/optimizing.md:83 Fenced code blocks should have a language specified
- java/operating-applications/optimizing.md:88 Fenced code blocks should have a language specified
- java/operating-applications/optimizing.md:93 Fenced code blocks should have a language specified
- java/operating-applications/optimizing.md:98 Fenced code blocks should have a language specified
- java/operating-applications/optimizing.md:103 Fenced code blocks should have a language specified
BraunMatthias
approved these changes
Apr 28, 2025
|
@renejeglinsky, @smahati, we still need a review from one of you. We'd like to have this merged before the upcoming CAP Java release. |
renejeglinsky
approved these changes
May 6, 2025
renejeglinsky
added a commit
that referenced
this pull request
May 6, 2025
Added section about how to use the https://github.com/SAP/cf-cli-java-plugin to run profiling with asprof. --------- Co-authored-by: BraunMatthias <[email protected]> Co-authored-by: Rene Jeglinsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added section about how to use the https://github.com/SAP/cf-cli-java-plugin to run profiling with asprof.