efi/preinstall: Refactor how the dTPM reset attack mitigation is enabled #477
+455
−346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisccoulson
force-pushed
the
preinstall-cleanup-partial-reset-attack-mitigation
branch
from
5e58e84 to
796133c
Compare
This adds a dedicated function for detecting whether the partial mitigation against discrete TPM reset attacks should be enabled. It also only enables it on Intel platforms, something that PR: canonical#472 achieves by making isTPMDiscrete lie instead. The associated CheckResultFlags are also cleaned up, keeping backwards compatibility with the original flags when unmarshalling.
chrisccoulson
force-pushed
the
preinstall-cleanup-partial-reset-attack-mitigation
branch
from
796133c to
532f070
Compare
Collaborator
|
@chrisccoulson there are conflicts now in this one |
Collaborator
Author
I've fixed that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dedicated function for detecting whether the partial
mitigation against discrete TPM reset attacks should be enabled. It also
only enables it on Intel platforms, something that PR: #472 achieves by
making
isTPMDiscretelie instead.The associated
CheckResultFlagsare also cleaned up, keeping backwardscompatibility with the original flags when unmarshalling.