[DPE-7322] Tweak database DBA role naming #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinclert-canonical
added
the
enhancement
sinclert-canonical
force-pushed
the
sinclert/7322/database-level-roles
branch
from
dcc4f53 to
44f94a6
Compare
sinclert-canonical
requested review from
delgod,
paulomach and
carlcsaposs-canonical
paulomach
approved these changes
Sep 17, 2025
|
@sinclert-canonical Include the |
paulomach
approved these changes
Sep 17, 2025
delgod
approved these changes
Sep 23, 2025
sinclert-canonical
force-pushed
the
sinclert/7322/database-level-roles
branch
from
be91492 to
fe98ee8
Compare
|
Commits squashed for clarity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the database-level DBA role naming in order to lift the restriction of having database names limited to 20 characters (down from the 32 character limit that MySQL supports). The agreed approach is to append a two-digit number at the end of the DBA role name, in order to distinguish it from other DBA role whose first set of characters is the same.
Proposed approach
Paulo and I think that using the Juju relation ID is a bad idea. It will heavily trim the space dedicated to the, potentially pruned database name (as relation IDs are several digits long), and introduced consistency issues when relations get broken, and new relations targeting the same database are created.
Instead, we propose the simple approach of incrementing an implicit counter, dictated by the number of roles which the naming schema would collide with.